[GitHub] arina-ielchiieva commented on a change in pull request #1577: DRILL-6912: NPE when other drillbit is already running

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1577: DRILL-6912: NPE when other drillbit is already running
URL: https://github.com/apache/drill/pull/1577#discussion_r242989610
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTwoDrillbitsWithSamePort.java
 ##########
 @@ -0,0 +1,68 @@
+package org.apache.drill.exec.server;
+
+import org.apache.drill.test.ClusterFixture;
+import org.apache.drill.test.ClusterFixtureBuilder;
+import org.apache.drill.test.ClusterTest;
+import org.junit.Test;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+public class TestTwoDrillbitsWithSamePort extends ClusterTest {
+
+
+  /**
+   * Provides test coverage for issue: DRILL-6912
+   */
+  @Test
+  public void gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit() throws Exception {
+    Drillbit drillbit = null;
+    Drillbit drillbit1 = null;
+
+    try {
+      ClusterFixtureBuilder fixtureBuilder = ClusterFixture.bareBuilder(dirTestWatcher).withLocalZk();
+      ClusterFixture clusterFixture = fixtureBuilder.build();
+      drillbit = clusterFixture.drillbit();
+
+      // creating another drillbit instance using same config
+      drillbit1 = new Drillbit(clusterFixture.config(), fixtureBuilder.configBuilder().getDefinitions(),
+          clusterFixture.serviceSet());
+
+      try {
+        drillbit1.run();
+      } catch (org.apache.drill.common.exceptions.UserException be) {
+        // it's expected that second drillbit can't be started because port is busy
+        assertTrue(be.getMessage().startsWith("RESOURCE ERROR: Drillbit could not bind to port 31010"));
+      }
+    } finally {
+      // preconditions
+      assertNotNull(drillbit);
+      assertNotNull(drillbit1);
+      assertNotNull("gracefulShutdownThread should be initialized, otherwise npe will be thrown from close()",
+          drillbit.gracefulShutdownThread);
+      // main test case
+      assertNotNull("gracefulShutdownThread should be initialized, otherwise npe will be thrown from close()",
 
 Review comment:
   npe -> NPE

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services