[GitHub] [incubator-brpc] jamesge commented on a change in pull request #981: add zone for bili discovery in fetching server nodes

[GitBox <gi...@apache.org>]

jamesge commented on a change in pull request #981: add zone for bili discovery in fetching server nodes
URL: https://github.com/apache/incubator-brpc/pull/981#discussion_r353576436
 
 

 ##########
 File path: src/brpc/policy/discovery_naming_service.cpp
 ##########
 @@ -349,8 +350,9 @@ int DiscoveryNamingService::GetServers(const char* service_name,
     servers->clear();
     Controller cntl;
     cntl.http_request().uri() = butil::string_printf(
-            "/discovery/fetchs?appid=%s&env=%s&status=%s", service_name,
-            FLAGS_discovery_env.c_str(), FLAGS_discovery_status.c_str());
+            "/discovery/fetchs?appid=%s&env=%s&status=%s&zone=%s", service_name,
+            FLAGS_discovery_env.c_str(), FLAGS_discovery_status.c_str(),
+            FLAGS_discovery_zone.c_str());
 
 Review comment:
   zone=xxx是不是应该按需添加？你可以把之前的结果存下来，然后按需string_appendf

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org