You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/12/20 18:39:00 UTC
[jira] [Work logged] (GOBBLIN-1757) Refactor ManifestBasedDataset to have common class for manifest reader & writer
[ https://issues.apache.org/jira/browse/GOBBLIN-1757?focusedWorklogId=834895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-834895 ]
ASF GitHub Bot logged work on GOBBLIN-1757:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/22 18:38
Start Date: 20/Dec/22 18:38
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3618:
URL: https://github.com/apache/gobblin/pull/3618#issuecomment-1359970583
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3618](https://codecov.io/gh/apache/gobblin/pull/3618?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9e6e55) into [master](https://codecov.io/gh/apache/gobblin/commit/d29bd9f32158bbc2cc9c9bbbdb90d565fb34b078?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d29bd9f) will **decrease** coverage by `3.14%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3618 +/- ##
============================================
- Coverage 46.91% 43.76% -3.15%
+ Complexity 10699 2062 -8637
============================================
Files 2128 408 -1720
Lines 83231 17618 -65613
Branches 9275 2151 -7124
============================================
- Hits 39044 7711 -31333
+ Misses 40598 9051 -31547
+ Partials 3589 856 -2733
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3618?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lin/data/management/copy/ManifestBasedDataset.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvTWFuaWZlc3RCYXNlZERhdGFzZXQuamF2YQ==) | | |
| [...che/gobblin/service/NoopGroupOwnershipService.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Ob29wR3JvdXBPd25lcnNoaXBTZXJ2aWNlLmphdmE=) | | |
| [...bblin/converter/avro/AvroToJsonBytesConverter.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXZyby1qc29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0F2cm9Ub0pzb25CeXRlc0NvbnZlcnRlci5qYXZh) | | |
| [...ules/orchestration/AzkabanGetProxyUsersStatus.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9BemthYmFuR2V0UHJveHlVc2Vyc1N0YXR1cy5qYXZh) | | |
| [...che/gobblin/types/AvroGenericRecordTypeMapper.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZXMvQXZyb0dlbmVyaWNSZWNvcmRUeXBlTWFwcGVyLmphdmE=) | | |
| [...les/flowgraph/datanodes/fs/FileSystemDataNode.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2ZzL0ZpbGVTeXN0ZW1EYXRhTm9kZS5qYXZh) | | |
| [...n/java/org/apache/gobblin/converter/Converter.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL0NvbnZlcnRlci5qYXZh) | | |
| [...in/java/org/apache/gobblin/dataset/Descriptor.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EZXNjcmlwdG9yLmphdmE=) | | |
| [...lin/runtime/job\_catalog/ImmutableFSJobCatalog.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2NhdGFsb2cvSW1tdXRhYmxlRlNKb2JDYXRhbG9nLmphdmE=) | | |
| [...main/java/org/apache/gobblin/types/TypeMapper.java](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZXMvVHlwZU1hcHBlci5qYXZh) | | |
| ... and [1712 more](https://codecov.io/gh/apache/gobblin/pull/3618/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 834895)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor ManifestBasedDataset to have common class for manifest reader & writer
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1757
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1757
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)