You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/12/29 15:44:09 UTC

[GitHub] [submarine] ByronHsu opened a new pull request #485: SUBMARINE-702. add unique identifier in server yaml

ByronHsu opened a new pull request #485:
URL: https://github.com/apache/submarine/pull/485


   ### What is this PR for?
   A few sentences describing the overall goals of the pull request's commits.
   First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
   
   In backend development, when building a new server image, we need to re-install the whole helm charts. However, installing the chart again is very inefficient. In fact, we only need to apply new docker image in server pod, and we can achieve so by calling helm upgrade.
   
   We use the same image name (apache/submarine:server-0.5.0) in each round of docker image building, and `helm upgrade` will not detect the change in image.
   
   Therefore, I add an unique identifier (timestamp) in `submarine-server.yaml` file. Every time we call `helm upgrade`, `submarine-server.yaml` will be different, so it will run the new server image.
   ```yaml
   # submarine-server.yaml
   ...
   template:
       metadata:
         labels:
           run: "{{ .Values.submarine.server.name }}"
         annotations:
           timestamp: {{ now | quote }} # this line
   ...
   
   # after parsing, it looks like:
   metadata:
     annotations:
       timestamp: 2020-12-29 20:54:20.74787 +0800 CST m=+0.907604406
   ```
   
   By doing so, we can make the backend development faster. We only need to call `helm upgrade submarine` after producing a new server image rather than re-installing the whole chart.
   
   ### What type of PR is it?
   [Improvement]
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-702
   
   ### How should this be tested?
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? Yes
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on pull request #485: SUBMARINE-702. Run new server docker image in helm upgrade

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #485:
URL: https://github.com/apache/submarine/pull/485#issuecomment-752306482


   @pingsutw Can u help me re run the Travis?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #485: SUBMARINE-702. Run new server docker image in helm upgrade

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #485:
URL: https://github.com/apache/submarine/pull/485


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org