You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/07/02 00:01:07 UTC

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6223#discussion_r199365966
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala ---
    @@ -1111,6 +1111,53 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
           math.atan(-0.1231231321321321111).toString)
       }
     
    +  @Test
    +  def testAtan2(): Unit = {
    +    testAllApis(
    +      'f25.atan2('f26),
    +      "f25.atan2(f26)",
    +      "ATAN2(f25, f26)",
    +      math.atan2(0.42.toByte, 0.toByte).toString)
    +
    +
    --- End diff --
    
    Remove this blank line would be better~ 


---