[GitHub] [superset] michellethomas commented on pull request #14885: fix: Query History cosmetic issues

[GitBox <gi...@apache.org>]

michellethomas commented on pull request #14885:
URL: https://github.com/apache/superset/pull/14885#issuecomment-854959765


   @AAfghahi I believe this PR created a few bugs in sqllab. It looks like the StatusAttributes do not all have the same structure, `scheduled` and `pending` do not have a `config` section or a `color`. Also there is a `fetching` status that has no entry in `StatusAttributes`. This causes an issue with `statusAttributes[q.state].config` [here](https://github.com/apache/superset/blob/eced51070803cf20c89da86a2bfc001ed50e7b47/superset-frontend/src/SqlLab/components/QueryTable/index.jsx#L258) and down below because at times there is no config in statusAttributes or q.state doesn't exist in statusAttributes. Can you either make the statusAttributes data more complete or handle the undefined data in a safe way and create tests for these cases? cc: @betodealmeida @hughhhh 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org