[GitHub] [james-project] Arsnael commented on a change in pull request #904: JAMES-3720 Fix temporary file leak in email reprocessing

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #904:
URL: https://github.com/apache/james-project/pull/904#discussion_r820482038



##########
File path: server/protocols/webadmin/webadmin-mailrepository/src/main/java/org/apache/james/webadmin/service/MailRepositoryStoreService.java
##########
@@ -86,13 +87,21 @@ public MailRepository createMailRepository(MailRepositoryPath repositoryPath, St
     }
 
     public Optional<MailDto> retrieveMail(MailRepositoryPath path, MailKey mailKey, Set<AdditionalField> additionalAttributes) throws MailRepositoryStore.MailRepositoryStoreException, MessagingException, InaccessibleFieldException {
-        return fecthMail(path, mailKey)
-            .map(Throwing.function((Mail mail) -> MailDto.fromMail(mail, additionalAttributes)).sneakyThrow());
+        Optional<Mail> mail = fecthMail(path, mailKey);

Review comment:
       Can we fix while we are at it the typo of that method? `fecthMail` -> `fetchMail`? :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org