You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2010/01/20 20:57:45 UTC
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument: HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Regis,
It looks like my "harmless" commit below broke some tests on Linux[1].
I think this means there is a problem with the code though since I don't
think line endings should be significant. Any chance you could take a
look?
Regards,
Mark.
[1] http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/37/testReport/
In message <20...@eris.apache.org>, hindessm@apache.org
writes:
>
> Author: hindessm
> Date: Thu Dec 10 08:38:15 2009
> New Revision: 889137
>
> URL: http://svn.apache.org/viewvc?rev=889137&view=rev
> Log:
> Add missing svn:eol-style properties.
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> he/harmony/tests/java/lang/instrument/HelloWorldTest.java (props changed)
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> he/harmony/tests/java/lang/instrument/InstrumentTestHelper.java (props chan
> ged)
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> he/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java (props ch
> anged)
>
> Propchange: harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
> -----------------------------------------------------------------------------
> -
> svn:eol-style = native
>
> Propchange: harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> org/apache/harmony/tests/java/lang/instrument/InstrumentTestHelper.java
> -----------------------------------------------------------------------------
> -
> svn:eol-style = native
>
> Propchange: harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> org/apache/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java
> -----------------------------------------------------------------------------
> -
> svn:eol-style = native
>
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument:
HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by Regis <xu...@gmail.com>.
On 2010-01-21 18:38, Mark Hindess wrote:
>
> In message<64...@mail.gmail.com>,
> regis xu writes:
>>
>> On Thu, Jan 21, 2010 at 4:51 PM, Mark Hindess
>> <ma...@googlemail.com>wrote:
>>>
>>> I'm not convinced it is just a local configuration problem. It works
>>> for me with an IBM VM but fails with DRLVM.
>>>
>>> Regards,
>>> Mark.
>>
>> It passed for me with both IBM vm and drlvm. Can you reproduce it on your
>> machine? Patch[1] may
>> help to find out what happened on the forked process.
>
> Not sure why it passed for you on DRLVM without -javaagent support but
> now the code freeze is over I've committed r901641 to re-applied the
> patch to support this flag and I expect the tests to be functional again
> now.
>
> Regards,
> Mark.
>
>
>
Hi Mark,
You are right, I used drlvm build with that fix. Thank you for re-applying that
patch, and it fixed instrument test failures according to latest test report.
--
Best Regards,
Regis.
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument: HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by Mark Hindess <ma...@googlemail.com>.
In message <20...@d12av01.megacenter.de.ibm.com>,
Mark Hindess writes:
>
> In message <64...@mail.gmail.com>,
> regis xu writes:
> >
> > On Thu, Jan 21, 2010 at 4:51 PM, Mark Hindess
> > <ma...@googlemail.com>wrote:
> > >
> > > I'm not convinced it is just a local configuration problem. It
> > > works for me with an IBM VM but fails with DRLVM.
> > >
> > > Regards, Mark.
> >
> > It passed for me with both IBM vm and drlvm. Can you reproduce it
> > on your machine? Patch[1] may help to find out what happened on the
> > forked process.
>
> Not sure why it passed for you on DRLVM without -javaagent support but
> now the code freeze is over I've committed r901641 to re-applied the
> patch to support this flag and I expect the tests to be functional
> again now.
I'm still seeing errors from these tests with DRLVM. In particular I'm
seeing ABORTs with an error like:
Element was inserted second time in MapEx!
from the child processes.
-Mark.
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument: HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by Mark Hindess <ma...@googlemail.com>.
In message <64...@mail.gmail.com>,
regis xu writes:
>
> On Thu, Jan 21, 2010 at 4:51 PM, Mark Hindess
> <ma...@googlemail.com>wrote:
> >
> > I'm not convinced it is just a local configuration problem. It works
> > for me with an IBM VM but fails with DRLVM.
> >
> > Regards,
> > Mark.
>
> It passed for me with both IBM vm and drlvm. Can you reproduce it on your
> machine? Patch[1] may
> help to find out what happened on the forked process.
Not sure why it passed for you on DRLVM without -javaagent support but
now the code freeze is over I've committed r901641 to re-applied the
patch to support this flag and I expect the tests to be functional again
now.
Regards,
Mark.
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument:
HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by regis xu <xu...@gmail.com>.
On Thu, Jan 21, 2010 at 4:51 PM, Mark Hindess
<ma...@googlemail.com>wrote:
>
> In message <64...@mail.gmail.com>,
> regis xu writes:
> >
> > On Thu, Jan 21, 2010 at 3:57 AM, Mark Hindess
> > <ma...@googlemail.com> wrote:
> > >
> > > Regis,
> > >
> > > It looks like my "harmless" commit below broke some tests on
> > > Linux[1]. I think this means there is a problem with the code
> > > though since I don't think line endings should be significant. Any
> > > chance you could take a look?
> > >
> > > Regards,
> > > Mark.
> > >
> > > [1]
> > >
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/37/testReport/
> >
> > I can't open this link, it report a 404 error. Can you paste
> > stack trace here? It passed on my Linux desktop. May be a
> > environment/configuration problems.
>
> Sorry, I linked to the oldest build with the problem, but there has
> probably been a new build and the oldest one was delete.
>
> I'm not convinced it is just a local configuration problem. It works
> for me with an IBM VM but fails with DRLVM.
>
> Regards,
> Mark.
>
>
>
It passed for me with both IBM vm and drlvm. Can you reproduce it on your
machine? Patch[1] may
help to find out what happened on the forked process.
[1]
Index:
modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
=====================================================================
---
modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
+++
modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
@@ -53,6 +53,11 @@ public class HelloWorldTest extends TestCase {
helper.run();
+ System.out.println("std err:");
+ System.out.println(helper.getStdErr());
+ System.out.println("std out:");
+ System.out.println(helper.getStdOut());
+
assertEquals(0, helper.getExitCode());
assertEquals("Hello World" + LINE_SEPARATOR, helper.getStdOut());
assertEquals("", helper.getStdErr());
@@ -72,6 +77,11 @@ public class HelloWorldTest extends TestCase {
helper.run();
+ System.out.println("std err:");
+ System.out.println(helper.getStdErr());
+ System.out.println("std out:");
+ System.out.println(helper.getStdOut());
+
assertEquals(0, helper.getExitCode());
assertEquals("Hello World" + LINE_SEPARATOR, helper.getStdOut());
assertEquals("", helper.getStdErr());
@@ -91,6 +101,11 @@ public class HelloWorldTest extends TestCase {
helper.run();
+ System.out.println("std err:");
+ System.out.println(helper.getStdErr());
+ System.out.println("std out:");
+ System.out.println(helper.getStdOut());
+
assertTrue(0 != helper.getExitCode());
assertTrue(helper.getStdErr().contains(
ClassNotFoundException.class.getName()));
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument: HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by Mark Hindess <ma...@googlemail.com>.
In message <64...@mail.gmail.com>,
regis xu writes:
>
> On Thu, Jan 21, 2010 at 3:57 AM, Mark Hindess
> <ma...@googlemail.com> wrote:
> >
> > Regis,
> >
> > It looks like my "harmless" commit below broke some tests on
> > Linux[1]. I think this means there is a problem with the code
> > though since I don't think line endings should be significant. Any
> > chance you could take a look?
> >
> > Regards,
> > Mark.
> >
> > [1]
> > http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/37/testReport/
>
> I can't open this link, it report a 404 error. Can you paste
> stack trace here? It passed on my Linux desktop. May be a
> environment/configuration problems.
Sorry, I linked to the oldest build with the problem, but there has
probably been a new build and the oldest one was delete.
I'm not convinced it is just a local configuration problem. It works
for me with an IBM VM but fails with DRLVM.
Regards,
Mark.
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument:
HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by Tim Ellison <t....@gmail.com>.
On 21/Jan/2010 08:04, regis xu wrote:
> On Thu, Jan 21, 2010 at 3:40 PM, Sean Qiu <se...@gmail.com> wrote:
>
>> Try this
>>
>>
>> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/38/testReport/
>>
>> Best Regards
>> Sean, Xiao Xia Qiu
>>
>>
> Thanks Sean.
>
> These tests fork new java process, which seems got error and return non-zero
> value. Can I login that server and see what happened exactly?
What do you expect to see with a login to the test machine?
As Sean says, you can get to the failing build on the hudson machine
http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/
and from there look at the workspace files, JUnit output, etc.
If there is something you need to do on the machine itself I have got a
login so I can go take a look, but I think most (all?) of the
information is available via the web UI.
Regards,
Tim
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument:
HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by regis xu <xu...@gmail.com>.
On Thu, Jan 21, 2010 at 3:40 PM, Sean Qiu <se...@gmail.com> wrote:
> Try this
>
>
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/38/testReport/
>
> Best Regards
> Sean, Xiao Xia Qiu
>
>
Thanks Sean.
These tests fork new java process, which seems got error and return non-zero
value. Can I login that server and see what happened exactly?
>
>
> 2010/1/21 regis xu <xu...@gmail.com>
>
> > On Thu, Jan 21, 2010 at 3:57 AM, Mark Hindess
> > <ma...@googlemail.com>wrote:
> >
> > >
> > > Regis,
> > >
> > > It looks like my "harmless" commit below broke some tests on Linux[1].
> > > I think this means there is a problem with the code though since I
> don't
> > > think line endings should be significant. Any chance you could take a
> > > look?
> > >
> > > Regards,
> > > Mark.
> > >
> > > [1]
> > >
> >
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/37/testReport/
> > >
> >
> > I can't open this link, it report a 404 error. Can you paste stack trace
> > here? It passed on my Linux desktop. May be a environment/configuration
> > problems.
> >
> >
> > > In message <20...@eris.apache.org>,
> > > hindessm@apache.org
> > > writes:
> > > >
> > > > Author: hindessm
> > > > Date: Thu Dec 10 08:38:15 2009
> > > > New Revision: 889137
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=889137&view=rev
> > > > Log:
> > > > Add missing svn:eol-style properties.
> > > >
> > > > Modified:
> > > >
> > >
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > > > he/harmony/tests/java/lang/instrument/HelloWorldTest.java (props
> > > changed)
> > > >
> > >
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > > > he/harmony/tests/java/lang/instrument/InstrumentTestHelper.java
> > (props
> > > chan
> > > > ged)
> > > >
> > >
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > > > he/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java
> > > (props ch
> > > > anged)
> > > >
> > > > Propchange:
> > > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > > > org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
> > > >
> > >
> >
> -----------------------------------------------------------------------------
> > > > -
> > > > svn:eol-style = native
> > > >
> > > > Propchange:
> > > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > > >
> org/apache/harmony/tests/java/lang/instrument/InstrumentTestHelper.java
> > > >
> > >
> >
> -----------------------------------------------------------------------------
> > > > -
> > > > svn:eol-style = native
> > > >
> > > > Propchange:
> > > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > > >
> > org/apache/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java
> > > >
> > >
> >
> -----------------------------------------------------------------------------
> > > > -
> > > > svn:eol-style = native
> > > >
> > >
> > >
> > >
> >
>
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument:
HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by Sean Qiu <se...@gmail.com>.
Try this
http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/38/testReport/
Best Regards
Sean, Xiao Xia Qiu
2010/1/21 regis xu <xu...@gmail.com>
> On Thu, Jan 21, 2010 at 3:57 AM, Mark Hindess
> <ma...@googlemail.com>wrote:
>
> >
> > Regis,
> >
> > It looks like my "harmless" commit below broke some tests on Linux[1].
> > I think this means there is a problem with the code though since I don't
> > think line endings should be significant. Any chance you could take a
> > look?
> >
> > Regards,
> > Mark.
> >
> > [1]
> >
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/37/testReport/
> >
>
> I can't open this link, it report a 404 error. Can you paste stack trace
> here? It passed on my Linux desktop. May be a environment/configuration
> problems.
>
>
> > In message <20...@eris.apache.org>,
> > hindessm@apache.org
> > writes:
> > >
> > > Author: hindessm
> > > Date: Thu Dec 10 08:38:15 2009
> > > New Revision: 889137
> > >
> > > URL: http://svn.apache.org/viewvc?rev=889137&view=rev
> > > Log:
> > > Add missing svn:eol-style properties.
> > >
> > > Modified:
> > >
> > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > > he/harmony/tests/java/lang/instrument/HelloWorldTest.java (props
> > changed)
> > >
> > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > > he/harmony/tests/java/lang/instrument/InstrumentTestHelper.java
> (props
> > chan
> > > ged)
> > >
> > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > > he/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java
> > (props ch
> > > anged)
> > >
> > > Propchange:
> > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > > org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
> > >
> >
> -----------------------------------------------------------------------------
> > > -
> > > svn:eol-style = native
> > >
> > > Propchange:
> > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > > org/apache/harmony/tests/java/lang/instrument/InstrumentTestHelper.java
> > >
> >
> -----------------------------------------------------------------------------
> > > -
> > > svn:eol-style = native
> > >
> > > Propchange:
> > harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > >
> org/apache/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java
> > >
> >
> -----------------------------------------------------------------------------
> > > -
> > > svn:eol-style = native
> > >
> >
> >
> >
>
Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument:
HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Posted by regis xu <xu...@gmail.com>.
On Thu, Jan 21, 2010 at 3:57 AM, Mark Hindess
<ma...@googlemail.com>wrote:
>
> Regis,
>
> It looks like my "harmless" commit below broke some tests on Linux[1].
> I think this means there is a problem with the code though since I don't
> think line endings should be significant. Any chance you could take a
> look?
>
> Regards,
> Mark.
>
> [1]
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/37/testReport/
>
I can't open this link, it report a 404 error. Can you paste stack trace
here? It passed on my Linux desktop. May be a environment/configuration
problems.
> In message <20...@eris.apache.org>,
> hindessm@apache.org
> writes:
> >
> > Author: hindessm
> > Date: Thu Dec 10 08:38:15 2009
> > New Revision: 889137
> >
> > URL: http://svn.apache.org/viewvc?rev=889137&view=rev
> > Log:
> > Add missing svn:eol-style properties.
> >
> > Modified:
> >
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > he/harmony/tests/java/lang/instrument/HelloWorldTest.java (props
> changed)
> >
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > he/harmony/tests/java/lang/instrument/InstrumentTestHelper.java (props
> chan
> > ged)
> >
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apac
> > he/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java
> (props ch
> > anged)
> >
> > Propchange:
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
> >
> -----------------------------------------------------------------------------
> > -
> > svn:eol-style = native
> >
> > Propchange:
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > org/apache/harmony/tests/java/lang/instrument/InstrumentTestHelper.java
> >
> -----------------------------------------------------------------------------
> > -
> > svn:eol-style = native
> >
> > Propchange:
> harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/
> > org/apache/harmony/tests/java/lang/instrument/agents/HelloWorldAgent.java
> >
> -----------------------------------------------------------------------------
> > -
> > svn:eol-style = native
> >
>
>
>