You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/06 08:33:39 UTC

[GitHub] [rocketmq] RongtongJin opened a new pull request #1700: [ISSUE #1699] Fix wrong topic max length in TopicValidator 

RongtongJin opened a new pull request #1700: [ISSUE #1699] Fix wrong topic max length in TopicValidator 
URL: https://github.com/apache/rocketmq/pull/1700
 
 
   ## What is the purpose of the change
   
   Fix wrong topic max length in TopicValidator when broker check topic length
   link #1699 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] duhenglucky merged pull request #1700: [ISSUE #1699] Fix wrong topic max length in TopicValidator

Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #1700: [ISSUE #1699] Fix wrong topic max length in TopicValidator 
URL: https://github.com/apache/rocketmq/pull/1700
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls commented on issue #1700: [ISSUE #1699] Fix wrong topic max length in TopicValidator

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1700: [ISSUE #1699] Fix wrong topic max length in TopicValidator 
URL: https://github.com/apache/rocketmq/pull/1700#issuecomment-571073921
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27931204/badge)](https://coveralls.io/builds/27931204)
   
   Coverage decreased (-0.06%) to 50.584% when pulling **d378af77ac4222b13c30e5548f380608c198f09f on RongtongJin:fix_topic_max_length** into **f7c21db6fc47b5a89f71162e2212be19dd88ecc7 on apache:develop**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services