You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/07 12:51:30 UTC

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #16409: add config maxUnloadBundleNumPerShedding for UniformLoadShedder

Demogorgon314 commented on code in PR #16409:
URL: https://github.com/apache/pulsar/pull/16409#discussion_r915835577


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2085,6 +2085,13 @@ public class ServiceConfiguration implements PulsarConfiguration {
     )
     private double loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold = 4;
 
+    @FieldContext(
+            dynamic = true,
+            category = CATEGORY_LOAD_BALANCER,
+            doc = "For each uniform balanced unload, the maximum number of bundles that can be unloaded."
+    )
+    private int maxUnloadBundleNumPerShedding = 2;

Review Comment:
   We may need to write a PIP to explain this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org