[jira] [Commented] (TAJO-236) Implement LogicalPlanVerifier to check if a logical plan is valid

["Jihoon Son (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797539#comment-13797539 ] 

Jihoon Son commented on TAJO-236:
---------------------------------

+1

This patch contains a good code which can be extended to include more rules.
It passes 'mvn clean install -DskipTests'

> Implement LogicalPlanVerifier to check if a logical plan is valid
> -----------------------------------------------------------------
>
>                 Key: TAJO-236
>                 URL: https://issues.apache.org/jira/browse/TAJO-236
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.2-incubating
>
>         Attachments: TAJO-236.patch
>
>
> The current Tajo does not have any verification system to check whether a logical plan is valid, or not. LogicalPlanVerifier will verify the followings of a logical plan:
>  * operand types checking
>  ** some operators have type restrictions. For example, plus(\+)'s operands must be numerical values.
>  * Table and column existence check. 
>  ** Examples are as follows:
>  *** a create table statement must check if the table already exists
>  *** columns included in select list must exist in corresponding tables.



--
This message was sent by Atlassian JIRA
(v6.1#6144)