[GitHub] [airflow] Taragolis commented on pull request #28363: make docker operators always use `DockerHook` for API calls

[GitBox <gi...@apache.org>]

Taragolis commented on PR #28363:
URL: https://github.com/apache/airflow/pull/28363#issuecomment-1369440373

   > However I have one request - could we also handle tls parameter In Hook possible to be passed as string for backwards compatibility?
   
   @potiuk, I will have a look again (today last day of my holidays) however based on [docker-py code](https://github.com/docker/docker-py/blob/5.0.3/docker/api/client.py#L85-L88) pass `tls` parameter as string no make sense at least in docker>=5.0.3 (our requirements). It will interpreters as `bool(tls)` if it not an instance of `TLSConfig`
   
   Internally we do not check type of this argument (if not count mypy), so if user pass string and this somehow work it will work.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org