You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2026/03/10 10:57:30 UTC

[PR] SOLR-18153: Fix File Upload in Documents Tab of Admin UI [solr]

epugh opened a new pull request, #4204:
URL: https://github.com/apache/solr/pull/4204

   https://issues.apache.org/jira/browse/SOLR-18153
   
   
   # Description
   
   uploading a file works, but due to how success/error is handled, you get a brower console error and therefore no visual feedback.
   
   # Solution
   
   The `.success()` and `.error()` methods on the `$http` promise were **deprecated in AngularJS 1.4** and **removed in AngularJS 1.6+**. Since the documents are still actually indexed (the POST itself succeeds), the underlying `$http.post()` works fine — it's only the callback wiring that was broken.
   
   # Tests
   
   Tested both positive and negative cases manually and I see the appropriate feedback.
   
   I also had claude check for OTHER situations like this, and this was the only one.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18153: Fix File Upload in Documents Tab of Admin UI [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #4204:
URL: https://github.com/apache/solr/pull/4204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-18153: Fix File Upload in Documents Tab of Admin UI [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4204:
URL: https://github.com/apache/solr/pull/4204#issuecomment-4038366504

   This is a pretty small change, so I'm looking to merge it Thursday or Friday at the latest...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org