You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jonashartwig <gi...@git.apache.org> on 2017/04/28 06:53:17 UTC
[GitHub] nifi pull request #1716: NIFI-3759 - avro append for PutHDFS processor
GitHub user jonashartwig opened a pull request:
https://github.com/apache/nifi/pull/1716
NIFI-3759 - avro append for PutHDFS processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ X ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ X ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ X ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes? (there were no tests for append)
- [ X ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jonashartwig/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1716.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1716
----
commit 542c2eb39408b868ee4575cd55d8cb953e72cdea
Author: jonashartwig <ne...@gmx.de>
Date: 2017-04-28T06:35:33Z
avro append for PutHDFS processor
commit a1aef73485f020f039ae238498f2a9f1662e766d
Author: jonashartwig <ne...@gmx.de>
Date: 2017-04-28T06:35:33Z
NIFI-3759 - avro append for PutHDFS processor
commit f33c0a7806faa138f8314c12972021efc4929eca
Author: jonashartwig <ne...@gmx.de>
Date: 2017-04-28T06:51:42Z
Merge branch 'master' of https://github.com/jonashartwig/nifi
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor
Posted by jonashartwig <gi...@git.apache.org>.
Github user jonashartwig commented on the issue:
https://github.com/apache/nifi/pull/1716
Hi, just to make sure: you want me to make a separate avro put processor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1716
@jonashartwig have you seen Joe's comment here?
https://issues.apache.org/jira/browse/NIFI-3759?focusedCommentId=15988716&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15988716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1716
Speed and overall project roadmap.
The approach introduced there brings significant advantages to the use of PutHDFS.
https://github.com/apache/nifi/pull/1712
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor
Posted by jonashartwig <gi...@git.apache.org>.
Github user jonashartwig commented on the issue:
https://github.com/apache/nifi/pull/1716
ah no, i did not. i did not get notifications :) thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor
Posted by jonashartwig <gi...@git.apache.org>.
Github user jonashartwig commented on the issue:
https://github.com/apache/nifi/pull/1716
hi, no I did not. why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1716
@jonashartwig thank you for your contribution.
I was looking at your code and was wondering if have you had a chance to see the put / fetch parquet @bbende submitted a few hours ago?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor
Posted by jonashartwig <gi...@git.apache.org>.
Github user jonashartwig commented on the issue:
https://github.com/apache/nifi/pull/1716
I am sorry. I do not quite follow your latest comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---