[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #10080: [To rel/1.2] Support tag/attribute on view

["MarcosZyk (via GitHub)" <gi...@apache.org>]

MarcosZyk commented on code in PR #10080:
URL: https://github.com/apache/iotdb/pull/10080#discussion_r1223756843


##########
server/src/main/java/org/apache/iotdb/db/metadata/mnode/mem/info/LogicalViewInfo.java:
##########
@@ -107,17 +109,19 @@ public String getAlias() {
   @Override
   public void setAlias(String alias) {
     // can not set alias for a logical view
+    throw new UnsupportedOperationException("View doesn't support alias");
   }
 
   @Override
   public long getOffset() {
     // tag/attribute's start offset in tag file
-    return -1;
+    return offset;
   }
 
   @Override
   public void setOffset(long offset) {
     // can not set offset for a logical view

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org