[GitHub] [druid] maytasm commented on a change in pull request #10929: add avro + kafka + schema registry integration test

[GitBox <gi...@apache.org>]

maytasm commented on a change in pull request #10929:
URL: https://github.com/apache/druid/pull/10929#discussion_r587880831



##########
File path: integration-tests/src/main/java/org/apache/druid/testing/DockerConfigProvider.java
##########
@@ -317,6 +317,17 @@ public String getHistoricalInternalHost()
         return "druid-historical";
       }
 
+      @Override
+      public String getSchemaRegistryHost()
+      {
+        return dockerIp + ":8085";
+      }
+
+      @Override
+      public String getSchemaRegistryInternalHost()
+      {
+        return "schema-registry:8085";
+      }

Review comment:
       I believe it's `docker-compose.base.yml` rather than `integration-tests/docker/docker-compose.schema-registry.yml` that would be relevant here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org