You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dennis Lundberg <de...@apache.org> on 2014/07/16 16:41:38 UTC

How to handle plugins that requires Java 6 (Was: Re: svn commit: r1611019 - /maven/plugins/trunk/pom.xml)

Hi

Fixing MPMD-182 meant bumping the Java requirement for
maven-pmd-plugin to Java 6. That in turn failed the Jenkins jobs that
have the plugins aggregator as its source. I've temporarily disable
the PMD Plugin module in the aggregator POM.

A more permament fix is needed. Would adding a profile that activates
on the presence of Java 6 be a suitable way to go?
I.e. add something like this to the plugins aggregator POM:

    <profile>
      <id>java-6</id>
      <modules>
        <module>maven-pmd-plugin</module>
      </modules>
      <activation>
        <jdk>1.6</jdk>
      </activation>
    </profile>


On Wed, Jul 16, 2014 at 4:21 PM,  <de...@apache.org> wrote:
> Author: dennisl
> Date: Wed Jul 16 14:21:02 2014
> New Revision: 1611019
>
> URL: http://svn.apache.org/r1611019
> Log:
> Disable maven-pmd-plugin from the aggregator, because it requires Java 6. We need to discuss how to handle such plugins in Jenkins jobs.
>
> Modified:
>     maven/plugins/trunk/pom.xml
>
> Modified: maven/plugins/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=1611019&r1=1611018&r2=1611019&view=diff
> ==============================================================================
> --- maven/plugins/trunk/pom.xml (original)
> +++ maven/plugins/trunk/pom.xml Wed Jul 16 14:21:02 2014
> @@ -74,7 +74,8 @@ under the License.
>      <module>maven-linkcheck-plugin</module>
>      <module>maven-patch-plugin</module>
>      <module>maven-pdf-plugin</module>
> -    <module>maven-pmd-plugin</module>
> +    <!-- Disabled because it requires Java 6. We need to discuss how to handle such plugins in Jenkins jobs. -->
> +    <!-- <module>maven-pmd-plugin</module> -->
>      <!--Moved to maven-3 profile as a workaround for MNG-3814
>      <module>maven-project-info-reports-plugin</module>-->
>      <module>maven-rar-plugin</module>
>
>



-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: How to handle plugins that requires Java 6 (Was: Re: svn commit: r1611019 - /maven/plugins/trunk/pom.xml)

Posted by Stephen Connolly <st...@gmail.com>.
We no longer support Maven 2.x, so Java 1.4 is off our radar. I think it is
perfectly reasonable at this point to stop cutting releases of plugins that
support running on Maven 2.x

Maven 3.0 has a minimum of Java 5 and the same goes for Maven 3.1... we
have not alerted users that those releases are being EOL'd... and in fact
given some of the edge cases with Maven 3.2.x it might not be advised just
yet

For Maven 3.2+ we have a minimum of Java 6 as the required runtime.

Once we cut Maven 4.0 IIRC we stated we would be only those JREs lines that
are (freely) supported by Oracle at the time of the initial release... so
unless we delay until JDK 9 that means that Maven 4.0 will be Java 7+ and
at that time we will be dropping all but the head minor version in the 3.x
line so we could then drop Java 5

But heck if we want to call a vote and say we will be dropping Java 5 as a
supported runtime (but still support toolchains for compiling and testing
on Java 5... I'd be +1


On 17 July 2014 01:35, Olivier Lamy <ol...@apache.org> wrote:

> +1
>
> But in mid 2014 we can probably think of being 1.6 required? (yup I
> know but we can start this discussion again every year :-) )
>
>
> On 17 July 2014 06:01, Hervé BOUTEMY <he...@free.fr> wrote:
> > +1 but the value should probably be a range: [1.6,)
> >
> > Regards,
> >
> > Hervé
> >
> > Le mercredi 16 juillet 2014 16:41:38 Dennis Lundberg a écrit :
> >> Hi
> >>
> >> Fixing MPMD-182 meant bumping the Java requirement for
> >> maven-pmd-plugin to Java 6. That in turn failed the Jenkins jobs that
> >> have the plugins aggregator as its source. I've temporarily disable
> >> the PMD Plugin module in the aggregator POM.
> >>
> >> A more permament fix is needed. Would adding a profile that activates
> >> on the presence of Java 6 be a suitable way to go?
> >> I.e. add something like this to the plugins aggregator POM:
> >>
> >>     <profile>
> >>       <id>java-6</id>
> >>       <modules>
> >>         <module>maven-pmd-plugin</module>
> >>       </modules>
> >>       <activation>
> >>         <jdk>1.6</jdk>
> >>       </activation>
> >>     </profile>
> >>
> >> On Wed, Jul 16, 2014 at 4:21 PM,  <de...@apache.org> wrote:
> >> > Author: dennisl
> >> > Date: Wed Jul 16 14:21:02 2014
> >> > New Revision: 1611019
> >> >
> >> > URL: http://svn.apache.org/r1611019
> >> > Log:
> >> > Disable maven-pmd-plugin from the aggregator, because it requires
> Java 6.
> >> > We need to discuss how to handle such plugins in Jenkins jobs.>
> >> > Modified:
> >> >     maven/plugins/trunk/pom.xml
> >> >
> >> > Modified: maven/plugins/trunk/pom.xml
> >> > URL:
> >> >
> http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=1611019&r1=1
> >> > 611018&r2=1611019&view=diff
> >> >
> =========================================================================
> >> > ===== --- maven/plugins/trunk/pom.xml (original)
> >> > +++ maven/plugins/trunk/pom.xml Wed Jul 16 14:21:02 2014
> >> > @@ -74,7 +74,8 @@ under the License.
> >> >
> >> >      <module>maven-linkcheck-plugin</module>
> >> >      <module>maven-patch-plugin</module>
> >> >      <module>maven-pdf-plugin</module>
> >> >
> >> > -    <module>maven-pmd-plugin</module>
> >> > +    <!-- Disabled because it requires Java 6. We need to discuss how
> to
> >> > handle such plugins in Jenkins jobs. --> +    <!--
> >> > <module>maven-pmd-plugin</module> -->
> >> >
> >> >      <!--Moved to maven-3 profile as a workaround for MNG-3814
> >> >      <module>maven-project-info-reports-plugin</module>-->
> >> >      <module>maven-rar-plugin</module>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
>
>
> --
> Olivier Lamy
> Ecetera: http://ecetera.com.au
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: How to handle plugins that requires Java 6 (Was: Re: svn commit: r1611019 - /maven/plugins/trunk/pom.xml)

Posted by Olivier Lamy <ol...@apache.org>.
+1

But in mid 2014 we can probably think of being 1.6 required? (yup I
know but we can start this discussion again every year :-) )


On 17 July 2014 06:01, Hervé BOUTEMY <he...@free.fr> wrote:
> +1 but the value should probably be a range: [1.6,)
>
> Regards,
>
> Hervé
>
> Le mercredi 16 juillet 2014 16:41:38 Dennis Lundberg a écrit :
>> Hi
>>
>> Fixing MPMD-182 meant bumping the Java requirement for
>> maven-pmd-plugin to Java 6. That in turn failed the Jenkins jobs that
>> have the plugins aggregator as its source. I've temporarily disable
>> the PMD Plugin module in the aggregator POM.
>>
>> A more permament fix is needed. Would adding a profile that activates
>> on the presence of Java 6 be a suitable way to go?
>> I.e. add something like this to the plugins aggregator POM:
>>
>>     <profile>
>>       <id>java-6</id>
>>       <modules>
>>         <module>maven-pmd-plugin</module>
>>       </modules>
>>       <activation>
>>         <jdk>1.6</jdk>
>>       </activation>
>>     </profile>
>>
>> On Wed, Jul 16, 2014 at 4:21 PM,  <de...@apache.org> wrote:
>> > Author: dennisl
>> > Date: Wed Jul 16 14:21:02 2014
>> > New Revision: 1611019
>> >
>> > URL: http://svn.apache.org/r1611019
>> > Log:
>> > Disable maven-pmd-plugin from the aggregator, because it requires Java 6.
>> > We need to discuss how to handle such plugins in Jenkins jobs.>
>> > Modified:
>> >     maven/plugins/trunk/pom.xml
>> >
>> > Modified: maven/plugins/trunk/pom.xml
>> > URL:
>> > http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=1611019&r1=1
>> > 611018&r2=1611019&view=diff
>> > =========================================================================
>> > ===== --- maven/plugins/trunk/pom.xml (original)
>> > +++ maven/plugins/trunk/pom.xml Wed Jul 16 14:21:02 2014
>> > @@ -74,7 +74,8 @@ under the License.
>> >
>> >      <module>maven-linkcheck-plugin</module>
>> >      <module>maven-patch-plugin</module>
>> >      <module>maven-pdf-plugin</module>
>> >
>> > -    <module>maven-pmd-plugin</module>
>> > +    <!-- Disabled because it requires Java 6. We need to discuss how to
>> > handle such plugins in Jenkins jobs. --> +    <!--
>> > <module>maven-pmd-plugin</module> -->
>> >
>> >      <!--Moved to maven-3 profile as a workaround for MNG-3814
>> >      <module>maven-project-info-reports-plugin</module>-->
>> >      <module>maven-rar-plugin</module>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>



-- 
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: How to handle plugins that requires Java 6 (Was: Re: svn commit: r1611019 - /maven/plugins/trunk/pom.xml)

Posted by Hervé BOUTEMY <he...@free.fr>.
+1 but the value should probably be a range: [1.6,)

Regards,

Hervé

Le mercredi 16 juillet 2014 16:41:38 Dennis Lundberg a écrit :
> Hi
> 
> Fixing MPMD-182 meant bumping the Java requirement for
> maven-pmd-plugin to Java 6. That in turn failed the Jenkins jobs that
> have the plugins aggregator as its source. I've temporarily disable
> the PMD Plugin module in the aggregator POM.
> 
> A more permament fix is needed. Would adding a profile that activates
> on the presence of Java 6 be a suitable way to go?
> I.e. add something like this to the plugins aggregator POM:
> 
>     <profile>
>       <id>java-6</id>
>       <modules>
>         <module>maven-pmd-plugin</module>
>       </modules>
>       <activation>
>         <jdk>1.6</jdk>
>       </activation>
>     </profile>
> 
> On Wed, Jul 16, 2014 at 4:21 PM,  <de...@apache.org> wrote:
> > Author: dennisl
> > Date: Wed Jul 16 14:21:02 2014
> > New Revision: 1611019
> > 
> > URL: http://svn.apache.org/r1611019
> > Log:
> > Disable maven-pmd-plugin from the aggregator, because it requires Java 6.
> > We need to discuss how to handle such plugins in Jenkins jobs.> 
> > Modified:
> >     maven/plugins/trunk/pom.xml
> > 
> > Modified: maven/plugins/trunk/pom.xml
> > URL:
> > http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=1611019&r1=1
> > 611018&r2=1611019&view=diff
> > =========================================================================
> > ===== --- maven/plugins/trunk/pom.xml (original)
> > +++ maven/plugins/trunk/pom.xml Wed Jul 16 14:21:02 2014
> > @@ -74,7 +74,8 @@ under the License.
> > 
> >      <module>maven-linkcheck-plugin</module>
> >      <module>maven-patch-plugin</module>
> >      <module>maven-pdf-plugin</module>
> > 
> > -    <module>maven-pmd-plugin</module>
> > +    <!-- Disabled because it requires Java 6. We need to discuss how to
> > handle such plugins in Jenkins jobs. --> +    <!--
> > <module>maven-pmd-plugin</module> -->
> > 
> >      <!--Moved to maven-3 profile as a workaround for MNG-3814
> >      <module>maven-project-info-reports-plugin</module>-->
> >      <module>maven-rar-plugin</module>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org