You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Dominik Wosiński (JIRA)" <ji...@apache.org> on 2018/09/25 14:26:00 UTC

[jira] [Commented] (FLINK-10424) Inconsistency between JsonSchemaConveerter and FlinkTypeFactory

    [ https://issues.apache.org/jira/browse/FLINK-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627440#comment-16627440 ] 

Dominik Wosiński commented on FLINK-10424:
------------------------------------------

Two possible ways of solving this issue are possible:
  - allow using _BigInteger_ Type Info in _FlinkTypeFactory_

  _-_ change _JsonSchemaConverter,_ so it returns Integer Type Info instead.

My opinion is that the _FlinkTypeFactory_ should be changed to stay consistent since _JsonSchemaConverter_ does return BigDecimal for __the _number_. So returning BigInteger for _integer_ is more consistent with the current behavior and more natural,

> Inconsistency between JsonSchemaConveerter and FlinkTypeFactory
> ---------------------------------------------------------------
>
>                 Key: FLINK-10424
>                 URL: https://issues.apache.org/jira/browse/FLINK-10424
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Dominik Wosiński
>            Assignee: Dominik Wosiński
>            Priority: Major
>
> There is still an inconsistency between _JsonSchemaConverter_ and _FlinkTypeFactory_ in case of using JsonSchema with _integer_ type field. _JsonSchemaConverter_ will return BigInteger Type Information for _integer_, but _FlinkTypeFactory_ currently does not support BigInteger Type Info and thus an exception will be thrown. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)