[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28061: [SPARK-31270][CORE] Expose executor metrics in task detail table in StageLevel

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #28061: [SPARK-31270][CORE] Expose executor metrics in task detail table in StageLevel
URL: https://github.com/apache/spark/pull/28061#discussion_r399734867
 
 

 ##########
 File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
 ##########
 @@ -572,7 +600,7 @@ $(document).ready(function () {
                                 var row1 = createRowMetadataForColumn(
                                     columnKey, taskMetricsResponse[columnKey], 4);
                                 var row2 = createRowMetadataForColumn(
-                                    "shuffleWriteTime", taskMetricsResponse[columnKey], 21);
+                                    "shuffleWriteTime", taskMetricsResponse[columnKey], 23);
 
 Review comment:
   > If possible, could you try to a
   
   Since add new column in Additional Metric, the column index is changed. So need to do this
   
   To be honest , I spend a lot of time to make sure the column change when add new column, since the spark web ui code changed a lot, since origin pr in `stagepage.js` have not do things like add column.
   
   If it's ok, this pr can be a demo for new develope of spark web UI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org