You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/09/21 20:27:53 UTC
Review Request 62478: Added the mark agent gone handler on the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62478/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445
Repository: mesos
Description
-------
This change adds the neccessary logic for handling the mark agent
gone call on the master. Once an agent is marked as gone, it's
not allowed to re-register with the Mesos master. GC'ing the
list of gone agents (it can grow unbounded) would be added in
a separate change.
Diffs
-----
src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655
src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
src/master/validation.cpp a6e6a90af7d8d1242e28e93af551a2096db62939
Diff: https://reviews.apache.org/r/62478/diff/1/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62478: Added the mark agent gone handler on the
master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62478/#review186306
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62478/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the neccessary logic for handling the mark agent
> gone call on the master. Once an agent is marked as gone, it's
> not allowed to re-register with the Mesos master. GC'ing the
> list of gone agents (it can grow unbounded) would be added in
> a separate change.
>
>
> Diffs
> -----
>
> src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655
> src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
> src/master/validation.cpp a6e6a90af7d8d1242e28e93af551a2096db62939
>
>
> Diff: https://reviews.apache.org/r/62478/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62478: Added the mark agent gone handler on the
master.
Posted by Anand Mazumdar <an...@apache.org>.
> On Sept. 26, 2017, 12:41 a.m., Vinod Kone wrote:
> > src/master/http.cpp
> > Lines 5312-5338 (patched)
> > <https://reviews.apache.org/r/62478/diff/2/?file=1833359#file1833359line5312>
> >
> > These warnings and return messages seem inconsistent? Can we make them consistent?
Looks like I updated it already in the second diff; so should be fine. Dropping
> On Sept. 26, 2017, 12:41 a.m., Vinod Kone wrote:
> > src/master/master.cpp
> > Line 7245 (original), 7237 (patched)
> > <https://reviews.apache.org/r/62478/diff/2/?file=1833361#file1833361line7302>
> >
> > Would've been better if this refactor was done in a dependent review.
Yep, my bad. Creating a separate patch
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62478/#review186177
-----------------------------------------------------------
On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62478/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the neccessary logic for handling the mark agent
> gone call on the master. Once an agent is marked as gone, it's
> not allowed to re-register with the Mesos master. GC'ing the
> list of gone agents (it can grow unbounded) would be added in
> a separate change.
>
>
> Diffs
> -----
>
> src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655
> src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
> src/master/validation.cpp a6e6a90af7d8d1242e28e93af551a2096db62939
>
>
> Diff: https://reviews.apache.org/r/62478/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62478: Added the mark agent gone handler on the
master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62478/#review186177
-----------------------------------------------------------
src/master/http.cpp
Lines 5312-5338 (patched)
<https://reviews.apache.org/r/62478/#comment262629>
These warnings and return messages seem inconsistent? Can we make them consistent?
src/master/http.cpp
Lines 5318 (patched)
<https://reviews.apache.org/r/62478/#comment262627>
s/is being/is already being/ to be more explicit?
src/master/http.cpp
Lines 5361 (patched)
<https://reviews.apache.org/r/62478/#comment262631>
is this indentation right?
src/master/master.cpp
Line 7245 (original), 7237 (patched)
<https://reviews.apache.org/r/62478/#comment262638>
Would've been better if this refactor was done in a dependent review.
- Vinod Kone
On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62478/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the neccessary logic for handling the mark agent
> gone call on the master. Once an agent is marked as gone, it's
> not allowed to re-register with the Mesos master. GC'ing the
> list of gone agents (it can grow unbounded) would be added in
> a separate change.
>
>
> Diffs
> -----
>
> src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655
> src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
> src/master/validation.cpp a6e6a90af7d8d1242e28e93af551a2096db62939
>
>
> Diff: https://reviews.apache.org/r/62478/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62478: Added the mark agent gone handler on the
master.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62478/#review186028
-----------------------------------------------------------
src/master/http.cpp
Lines 5308 (patched)
<https://reviews.apache.org/r/62478/#comment262390>
Send ServiceUnavailable here too and bring it down
src/master/http.cpp
Lines 5374 (patched)
<https://reviews.apache.org/r/62478/#comment262392>
is not currently registered (unreachable/recovered).
src/master/master.cpp
Lines 7239 (patched)
<https://reviews.apache.org/r/62478/#comment262407>
Separate this into two functions.
- Anand Mazumdar
On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62478/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the neccessary logic for handling the mark agent
> gone call on the master. Once an agent is marked as gone, it's
> not allowed to re-register with the Mesos master. GC'ing the
> list of gone agents (it can grow unbounded) would be added in
> a separate change.
>
>
> Diffs
> -----
>
> src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655
> src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
> src/master/validation.cpp a6e6a90af7d8d1242e28e93af551a2096db62939
>
>
> Diff: https://reviews.apache.org/r/62478/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>