You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/25 02:15:05 UTC

[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

StevenLuMT opened a new pull request, #2957:
URL: https://github.com/apache/bookkeeper/pull/2957

   Descriptions of the changes in this PR:
   
   
   
   ### Motivation
   
   bugfix:
   when enforceMinNumRacksPerWriteQuorum is false, no need to check racks in quorum
   when all bookies is in a rack,when the old bookie node is offline for machine is broken,the ReplicationWorker want call method BookKeeperAdmin.getReplacementBookiesByIndexes, but find minNumRacksPerWriteQuorum(default value is 2) is large than racksInQuorum,but enforceMinNumRacksPerWriteQuorum(default value is false) is not open for checking this rack.
   
   So I think we should charge enforceMinNumRacksPerWriteQuorum is closed,no need to check rack's information
    
   <img width="668" alt="image" src="https://user-images.githubusercontent.com/42990025/147206534-bf9f3568-4463-4727-89c4-85ef0f3e9924.png">
   <img width="808" alt="image" src="https://user-images.githubusercontent.com/42990025/147207554-8290677f-23e1-4077-84f3-ba7b352a8a30.png">
   
   case :
   1) minNumRacksPerWriteQuorum(default value is 2)
   2) enforceMinNumRacksPerWriteQuorum(default value is false)
   3) no rack config(just use default-rack)
   isEnsembleAdheringToPlacementPolicy will return false, then it will be unexpected
   
   ### Changes
   
   bugfix: when enforceMinNumRacksPerWriteQuorum is false, no need to check racks in quorum


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.

StevenLuMT commented on PR #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1225348876

   fix old workflow,please see #3455 for detail


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT closed pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.

StevenLuMT closed pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy
URL: https://github.com/apache/bookkeeper/pull/2957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org