You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Doug Cutting <cu...@apache.org> on 2006/03/01 20:52:13 UTC

solar -> solr

There are still a lot of references to "Solar", both in the sources and 
in the documentation.  I just fixed a few of the obvious ones in the 
documentation.

Doug

Re: solar -> solr

Posted by Chris Hostetter <ho...@fucit.org>.
: >   "source" => $HeadURL:$
: >   "sourceid" => $Revision:$  (aka: $LastChangedRevision:$)
:
: Revision or Id?  Revision doesn't have the date, but Id has redundant
: and unneeded info.

Er, sorry ... right, $Id:$ ... i was getting SolrInfoMBean.getCvsId() in
the confused with SolrInfoMBean.getVersion()  (which in my plugins uses
$Revision:$ ... but that may not make sense everywhere)

to recap:

  * in SolrInfoMBean;
     * replace getCvsId() with getSourceId()
     * replace getCvsSource() with getSource()
     * remove getCvsName()
  * in all Solr core classes that impliment SolrInfoMBean:
     * getSourceId() should use $Id:$
     * getSource() should use $HeadURL:$
     * remove getCvsName()
     * getVersion() should keep using whatever it uses now.





-Hoss


Re: solar -> solr

Posted by Yonik Seeley <ys...@gmail.com>.
On 3/2/06, Chris Hostetter <ho...@fucit.org> wrote:
> yeah ...
>
>   "source" => $HeadURL:$
>   "sourceid" => $Revision:$  (aka: $LastChangedRevision:$)

Revision or Id?  Revision doesn't have the date, but Id has redundant
and unneeded info.

Examples:
$Revision: 144 $.
$Id: calc.c 148 2002-07-28 21:30:43Z sally $

-Yonik

Re: solar -> solr

Posted by Chris Hostetter <ho...@fucit.org>.
: name: updateHandler
: class: org.apache.solr.update.DirectUpdateHandler2
: version: 1.0
: description: Update handler that efficiently directly updates the
: on-disk main lucene index
: cvsid: $Id: DirectUpdateHandler2.java,v 1.12 2005/06/17 20:44:42 yonik Exp $
: cvssrc: $Source:
: /cvs/main/searching/solr/solarcore/src/solr/DirectUpdateHandler2.java,v
: $
: cvstag: $Name: $
:
: Subversion doesn't have anything for $Name:$, should cvstag just be removed?
: Perhaps cvsid and cvssrc should be renamed to something more neutral also.

: cvssrc->source
: cvsid->sourceId?

yeah ...

  "source" => $HeadURL:$
  "sourceid" => $Revision:$  (aka: $LastChangedRevision:$)

...it seems like the recommended approach for people who want something
like $Name:$ in their releases is to use "svnversion -n ." to get the
revision number being used, and shove that into whatever variable you want
at build time.

This could probably be done fairly easy using the ant <replace> tag, but
it would mean calling out to the shell to execute "svnversion -n ."

I'm personally very fond of $Name:$, but i'm not sure if it's worth that
much work.


-Hoss


Re: solar -> solr

Posted by Yonik Seeley <ys...@gmail.com>.
On 3/1/06, Chris Hostetter <ho...@fucit.org> wrote:
> 4) $Source:$ tags that still have CNET paths.
>    ...I'm suprised Subversion doesn't support the $Source:$

It looks like HeadURL is a superset of Source.
Subversion also doesn't do keyword expansion by default - you have to
set the right properties on the file.

Here is what stuff the [INFO] link off the admin page displays about
each registered component:

name: updateHandler
class: org.apache.solr.update.DirectUpdateHandler2
version: 1.0
description: Update handler that efficiently directly updates the
on-disk main lucene index
cvsid: $Id: DirectUpdateHandler2.java,v 1.12 2005/06/17 20:44:42 yonik Exp $
cvssrc: $Source:
/cvs/main/searching/solr/solarcore/src/solr/DirectUpdateHandler2.java,v
$
cvstag: $Name: $

Subversion doesn't have anything for $Name:$, should cvstag just be removed?
Perhaps cvsid and cvssrc should be renamed to something more neutral also.
cvssrc->source
cvsid->sourceId?

-Yonik

Re: solar -> solr

Posted by Chris Hostetter <ho...@fucit.org>.
: I'll do a grep run and see what else I can change.

it seems like they fall into four main categories...

1) SolrTest's schema
2) stuff in web.xml that may not even be getting used anymore
3) a handfull of comments in java files
4) $Source:$ tags that still have CNET paths.
   ...I'm suprised Subversion doesn't support the $Source:$


I'm 90% sure the wiki is clean, but every time i 've tried searching hte
last few days, it times out.

-Hoss


Re: solar -> solr

Posted by Yonik Seeley <ys...@gmail.com>.
On 3/1/06, Doug Cutting <cu...@apache.org> wrote:
> There are still a lot of references to "Solar", both in the sources and
> in the documentation.  I just fixed a few of the obvious ones in the
> documentation.

Sorry bout that... I'm so used to reading both now that I didn't even notice.
I'll do a grep run and see what else I can change.

-Yonik