You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/08 08:50:46 UTC
[GitHub] codecov-io commented on issue #3453: Introduce a AttachmentStore SPI
codecov-io commented on issue #3453: Introduce a AttachmentStore SPI
URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395695075
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr&el=h1) Report
> Merging [#3453](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/c5f05d972d0c20bc2ea1f75680862c9cf08c7daa?src=pr&el=desc) will **increase** coverage by `0.26%`.
> The diff coverage is `94.02%`.
[](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3453 +/- ##
==========================================
+ Coverage 75.26% 75.53% +0.26%
==========================================
Files 128 130 +2
Lines 6081 6152 +71
Branches 398 401 +3
==========================================
+ Hits 4577 4647 +70
- Misses 1504 1505 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `83.33% <ø> (ø)` | :arrow_up: |
| [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.64% <100%> (+0.28%)` | :arrow_up: |
| [...ala/whisk/core/database/CouchDbStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlN0b3JlUHJvdmlkZXIuc2NhbGE=) | `81.81% <100%> (+1.81%)` | :arrow_up: |
| [...rc/main/scala/whisk/core/database/StoreUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvU3RvcmVVdGlscy5zY2FsYQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `98.58% <100%> (+1.23%)` | :arrow_up: |
| [.../scala/whisk/core/database/AttachmentInliner.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXR0YWNobWVudElubGluZXIuc2NhbGE=) | `100% <100%> (ø)` | :arrow_up: |
| [...la/whisk/core/database/ArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RTdG9yZVByb3ZpZGVyLnNjYWxh) | `66.66% <66.66%> (ø)` | |
| [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `76.92% <90.56%> (+2.88%)` | :arrow_up: |
| [...k/core/database/memory/MemoryAttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUF0dGFjaG1lbnRTdG9yZS5zY2FsYQ==) | `94.28% <94.28%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr&el=footer). Last update [c5f05d9...477b1f9](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services