Incorrect filenames when checking out under Windows

[Daniel Sahlberg <da...@gmail.com>]

Hi,

I'm trying to check out a repository where someone has has committed files
with illegal characters (according to Windows).

[[[
D:\Dev>svn co https://svn.apache.org/repos/private/pmc/subversion
subversion_private
A    subversion_private\security
[... lots of files ...]
A
subversion_private\pr\wandisco-web-site-snapshots\subversion.wandisco.com_subversion-book-20101228-1755pm_files\moopopup01.css
svn: E155009: Failed to run the WC DB work queue associated with
'D:\Dev\subversion_private\pr\wandisco-web-site-snapshots\subversion.wandisco.com_subversion-book-20101228-1755pm_files',
work item 328 (file-install
pr/wandisco-web-site-snapshots/wandisco.com_php_pr.php?rss=0&prdate=2010-12-20.html
1 0 1 1)
svn: E720123: Can't move 'D:\Dev\subversion_private\.svn\tmp\svn-53E99F51'
to
'D:\Dev\subversion_private\pr\wandisco-web-site-snapshots\wandisco.com_php_pr.php?rss=0&prdate=2010-12-20.html':
Felaktig syntax för filnamn, katalognamn eller volymetikett.
]]]

I believe the swedish error message translates to "The filename, directory
name, or volume label syntax is incorrect".

It seems to have been discussed in
https://svn.haxx.se/users/archive-2014-08/0012.shtml

I also found https://issues.apache.org/jira/browse/SVN-4098 seems to be the
issue. I'll go to dev@.

Apart from the obvious suggestions "don't do that" there was a suggestion
to add a filter of illegal characters and to mark files containing these as
not-present instead of corrupting the whole WC.

Does anyone have a pointer where to start looking?

Kind regards
Daniel Sahlberg

Re: Incorrect filenames when checking out under Windows

[Daniel Shahaf <d....@daniel.shahaf.name>]

Daniel Sahlberg wrote on Wed, Aug 04, 2021 at 22:17:45 +0200:
> Apart from the obvious suggestions "don't do that" there was a suggestion
> to add a filter of illegal characters and to mark files containing these as
> not-present instead of corrupting the whole WC.
> 
> Does anyone have a pointer where to start looking?

subversion/libsvn_wc/wc-metadata.sql:32

"server-excluded" there basically means "We know there's a node by that
name, but we don't have its contents".  We could add another value to
that enum to mean "we have the node's name _and_ its contents, but we
can't create it on-disk because the FS won't allow us to do that.".

That enum already has a value literally called "not-present" but it's
unrelated.

Cheers,

Daniel