You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2026/07/09 19:58:44 UTC
[PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
shahar1 opened a new pull request, #69671:
URL: https://github.com/apache/airflow/pull/69671
Following review feedback on #69212, the OpenLineage provider e2e tests are consolidated into the existing `airflow-e2e-tests/` framework instead of the standalone `providers-e2e-tests/` framework introduced there.
`airflow-e2e-tests/` already hosts deployed-stack suites for providers (Elasticsearch/OpenSearch remote logging, Kafka event-driven), so the separate framework duplicated setup that already exists. OpenLineage now runs as an `openlineage` `--e2e-test-mode`: it reuses the shared docker-compose base, the testcontainers conftest, and the shared `AirflowClient`, adding only a compose overlay for the OpenLineage env config and a small runner that drives the provider's system-test DAGs.
The standalone `providers-e2e-tests/` tree, its `breeze testing providers-e2e-tests` command, its uv workspace member and its dedicated CI workflow are removed. The older-Airflow compatibility matrix (the only feature unique to that framework) is dropped along with it.
related: #69212
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.8)
Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #69671:
URL: https://github.com/apache/airflow/pull/69671#issuecomment-4929581061
ALMOST !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #69671:
URL: https://github.com/apache/airflow/pull/69671#issuecomment-4929286598
> NICE!
The credit goes to @jason810496 for the idea :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "kacpermuda (via GitHub)" <gi...@apache.org>.
kacpermuda commented on code in PR #69671:
URL: https://github.com/apache/airflow/pull/69671#discussion_r3558012762
##########
airflow-e2e-tests/tests/airflow_e2e_tests/openlineage_tests/prepare_dags.py:
##########
@@ -30,41 +30,21 @@
from __future__ import annotations
-import os
import shutil
from pathlib import Path
-HERE = Path(__file__).resolve().parent
-AIRFLOW_ROOT_PATH = HERE.parents[1]
+from airflow_e2e_tests.constants import AIRFLOW_ROOT_PATH
-# Example DAGs that need a minimum Airflow version. When running against an older version, the DAG
Review Comment:
Let's see when the compat are back if this chunk and other version-related from this file are needed, may need to be re-added.
##########
providers-e2e-tests/openlineage/README.md:
##########
Review Comment:
Can we keep this README close to the OL tests? Even thought the layout needs adjusting, it still explain how the tests are executed and the logic behind it, very useful for debugging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 merged PR #69671:
URL: https://github.com/apache/airflow/pull/69671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #69671:
URL: https://github.com/apache/airflow/pull/69671#issuecomment-4929205453
<img width="171" height="59" alt="Screenshot 2026-07-09 at 22 23 29" src="https://github.com/user-attachments/assets/eeb49185-7837-4de4-9f4d-729d15c3f6c9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #69671:
URL: https://github.com/apache/airflow/pull/69671#issuecomment-4929217477
Love it !!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #69671:
URL: https://github.com/apache/airflow/pull/69671#issuecomment-4932384985
CC: @kacpermuda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #69671:
URL: https://github.com/apache/airflow/pull/69671#issuecomment-4931267848
> > NICE!
>
> The credit goes to @jason810496 for the idea :)
Thanks Shahar for consolidating this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "kacpermuda (via GitHub)" <gi...@apache.org>.
kacpermuda commented on code in PR #69671:
URL: https://github.com/apache/airflow/pull/69671#discussion_r3557983463
##########
.github/workflows/additional-prod-image-tests.yml:
##########
@@ -329,34 +325,17 @@ jobs:
e2e_test_mode: "go_sdk"
if: inputs.canary-run == 'true' || inputs.run-go-sdk-e2e-tests == 'true'
- test-providers-e2e-tests-openlineage:
- name: "Provider E2E tests openlineage"
- uses: ./.github/workflows/providers-e2e-tests.yml
- with:
- provider: "openlineage"
- provider-display-name: "OpenLineage"
- runners: ${{ inputs.runners }}
- platform: ${{ inputs.platform }}
- default-python-version: "${{ inputs.default-python-version }}"
- use-uv: ${{ inputs.use-uv }}
- if: inputs.canary-run == 'true' || inputs.run-providers-e2e-tests-openlineage == 'true'
-
- test-providers-e2e-tests-openlineage-compat:
Review Comment:
I think that it's valuable to keep all the versions in compat, as OL is one these "meta" providers that has a lot of reliability on core, so it's easy to break some compatibility by something that looks like small and innocent change. These compat jobs are already using airflow images published, just adding some providers on top of it, so they are not very heavy. I do however understand the need to save the CI resources, I think if it turns out that it is consuming too much, we can always trigger these compat jobs only for scheduled runs on main (those 4 times a day if I remember correctly?) And only run them with prod image for PRs, that way, we can reduce the resource usage and still keep the early bug detection.
How does this sound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "kacpermuda (via GitHub)" <gi...@apache.org>.
kacpermuda commented on code in PR #69671:
URL: https://github.com/apache/airflow/pull/69671#discussion_r3557651214
##########
.github/workflows/additional-prod-image-tests.yml:
##########
@@ -329,34 +325,17 @@ jobs:
e2e_test_mode: "go_sdk"
if: inputs.canary-run == 'true' || inputs.run-go-sdk-e2e-tests == 'true'
- test-providers-e2e-tests-openlineage:
- name: "Provider E2E tests openlineage"
- uses: ./.github/workflows/providers-e2e-tests.yml
- with:
- provider: "openlineage"
- provider-display-name: "OpenLineage"
- runners: ${{ inputs.runners }}
- platform: ${{ inputs.platform }}
- default-python-version: "${{ inputs.default-python-version }}"
- use-uv: ${{ inputs.use-uv }}
- if: inputs.canary-run == 'true' || inputs.run-providers-e2e-tests-openlineage == 'true'
-
- test-providers-e2e-tests-openlineage-compat:
Review Comment:
Will review in a second, but first spot is that we would no longer run on previous airflow versions, which was crucial. I do not see those in the current CI as well, so it was removed. Any reason for that? I thought it's just about moving to different directory in repo rather than changing the logic of the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "kacpermuda (via GitHub)" <gi...@apache.org>.
kacpermuda commented on code in PR #69671:
URL: https://github.com/apache/airflow/pull/69671#discussion_r3558049095
##########
providers-e2e-tests/openlineage/README.md:
##########
Review Comment:
Can we keep this README close to the new OL tests directory? Even thought the layout needs adjusting, it still explain how the tests are executed and the logic behind it, very useful for debugging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #69671:
URL: https://github.com/apache/airflow/pull/69671#discussion_r3557846956
##########
.github/workflows/additional-prod-image-tests.yml:
##########
@@ -329,34 +325,17 @@ jobs:
e2e_test_mode: "go_sdk"
if: inputs.canary-run == 'true' || inputs.run-go-sdk-e2e-tests == 'true'
- test-providers-e2e-tests-openlineage:
- name: "Provider E2E tests openlineage"
- uses: ./.github/workflows/providers-e2e-tests.yml
- with:
- provider: "openlineage"
- provider-display-name: "OpenLineage"
- runners: ${{ inputs.runners }}
- platform: ${{ inputs.platform }}
- default-python-version: "${{ inputs.default-python-version }}"
- use-uv: ${{ inputs.use-uv }}
- if: inputs.canary-run == 'true' || inputs.run-providers-e2e-tests-openlineage == 'true'
-
- test-providers-e2e-tests-openlineage-compat:
Review Comment:
It was an AI overusage side-effect, apologies for that :)
I will restore the coverage for older versions, hopefully Jarek won't be disappointed by increase in number of lines.
However, just wondering if it's really useful to run it for **all** old 3.X versions (3.0, 3.1, 3.2, 3.3), and not only the oldest one (3.0). We're currently in shortage of CI resources, so each job adds its own overhead (multiply by number of PRs per time unit) - which we try to reduce in these days.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "kacpermuda (via GitHub)" <gi...@apache.org>.
kacpermuda commented on code in PR #69671:
URL: https://github.com/apache/airflow/pull/69671#discussion_r3559680321
##########
.github/workflows/additional-prod-image-tests.yml:
##########
@@ -329,34 +325,17 @@ jobs:
e2e_test_mode: "go_sdk"
if: inputs.canary-run == 'true' || inputs.run-go-sdk-e2e-tests == 'true'
- test-providers-e2e-tests-openlineage:
- name: "Provider E2E tests openlineage"
- uses: ./.github/workflows/providers-e2e-tests.yml
- with:
- provider: "openlineage"
- provider-display-name: "OpenLineage"
- runners: ${{ inputs.runners }}
- platform: ${{ inputs.platform }}
- default-python-version: "${{ inputs.default-python-version }}"
- use-uv: ${{ inputs.use-uv }}
- if: inputs.canary-run == 'true' || inputs.run-providers-e2e-tests-openlineage == 'true'
-
- test-providers-e2e-tests-openlineage-compat:
Review Comment:
One more question around this, I see that we moved compat to canary only, will the "full tests needed" label still trigger these compats? It would be awesome to not run by default on every OL PR, but be able to trigger them for some bigger changes. Not sure how this label works now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69671:
URL: https://github.com/apache/airflow/pull/69671#issuecomment-4941401948
### Backport failed to create: v3-3-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/29135585870'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-3-test</td>
<td><a href="https://github.com/apache/airflow/commit/37783b80006c3997526967e75ecf95fac090f1a9"><img src='https://img.shields.io/badge/Commit-37783b8-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 37783b8 v3-3-test
```
This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate OpenLineage e2e tests into airflow-e2e-tests [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #69671:
URL: https://github.com/apache/airflow/pull/69671#discussion_r3557846956
##########
.github/workflows/additional-prod-image-tests.yml:
##########
@@ -329,34 +325,17 @@ jobs:
e2e_test_mode: "go_sdk"
if: inputs.canary-run == 'true' || inputs.run-go-sdk-e2e-tests == 'true'
- test-providers-e2e-tests-openlineage:
- name: "Provider E2E tests openlineage"
- uses: ./.github/workflows/providers-e2e-tests.yml
- with:
- provider: "openlineage"
- provider-display-name: "OpenLineage"
- runners: ${{ inputs.runners }}
- platform: ${{ inputs.platform }}
- default-python-version: "${{ inputs.default-python-version }}"
- use-uv: ${{ inputs.use-uv }}
- if: inputs.canary-run == 'true' || inputs.run-providers-e2e-tests-openlineage == 'true'
-
- test-providers-e2e-tests-openlineage-compat:
Review Comment:
It was an AI overdose side-effect, apologies for that :)
I will restore the coverage for older versions, hopefully Jarek won't be disappointed by increase in number of lines.
However, just wondering if it's really useful to run it for **all** old 3.X versions (3.0, 3.1, 3.2, 3.3), and not only the oldest one (3.0). We're currently in shortage of CI resources, so each job adds its own overhead (multiply by number of PRs per time unit) - which we try to reduce in these days.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org