You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/05 10:21:53 UTC
[GitHub] [incubator-seatunnel] legendtkl opened a new pull request, #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
legendtkl opened a new pull request, #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800
## Purpose of this pull request
fix https://github.com/apache/incubator-seatunnel/issues/1799
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119193658
Hi, @CalvinKirs , thanks for the reply.
I have just updated the doc.
Thanks,
Kelu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#discussion_r866443982
##########
seatunnel-core/seatunnel-core-flink/src/test/resources/app.conf:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+ # You can set flink configuration here
+ execution.parallelism = 1
+ execution.checkpoint.interval = 10000
+ execution.checkpoint.data-uri = "hdfs://localhost:9000/checkpoint"
+}
+
+source {
+ # This is a example input plugin **only for test and demonstrate the feature input plugin**
+ FakeSourceStream {
+ result_table_name = "fake"
+ field_name = "name,age"
+ }
+
+ # If you would like to get more information about how to configure seatunnel and see full list of input plugins,
+ # please go to https://seatunnel.apache.org/docs/flink/configuration/source-plugins/Fake
+}
+
+transform {
+ sql {
+ sql = "select name,age from fake"
+ }
+
+ # If you would like to get more information about how to configure seatunnel and see full list of filter plugins,
+ # please go to https://seatunnel.apache.org/docs/flink/configuration/transform-plugins/Sql
+}
+
+sink {
+ ConsoleSink {}
+
+ # If you would like to get more information about how to configure seatunnel and see full list of output plugins,
+ # please go to https://seatunnel.apache.org/docs/flink/configuration/sink-plugins/Console
+}
Review Comment:
Need empty end line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119226069
Hi, @BenJFan , thanks for the reply. Let's have a brief discussion.
There are several pros in this implementation setting the configurations in '-D':
- simple. Config in shell is simple enough, and Flink client will do much work for us. If we set them in environment, we have to set them for each environments (stream, batch, table)
- upgrade. Environment API upgrade has no side effect to our current implementation.
What do you think?
Thanks,
Kelu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119232864
> Hi, @BenJFan , thanks for the reply. Let's have a brief discussion.
>
> There are several pros in this implementation setting the configurations in '-D':
>
> * simple. Config in shell is simple enough, and Flink client will do much work for us. If we set them in environment, we have to set them for each environments (stream, batch, table)
> * upgrade. Environment API upgrade has no side effect to our current implementation.
>
> What do you think?
>
> Thanks, Kelu
Got it. You are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1118405841
Hi, @leo65535 , @ruanwenjun , would you help review this PR when you'r free?
Thanks,
Kelu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119214277
I think it is better to inject dynamic configurations when creating the Flink Environment than in the shell command. @ruanwenjun @legendtkl What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119230663
> I think it is better to inject dynamic configurations when creating the Flink Environment than in the shell command. @ruanwenjun @legendtkl What do you think?
I think we can use `-D` to implement this. You are right, inject configuration in creating environment is a better way, this way can check the config and do some other control, but this will need to do some complex change. As kelu said, we may need to pay attention to deal the different version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119215433
I think it is better to inject dynamic configurations when creating the Flink Environment than in the shell command. @ruanwenjun @legendtkl What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1800: [Feature][Seatunnel-core-fline] Support Flink dynamic configurations
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #1800:
URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119238517
Well done~ thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org