You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/11/24 03:31:52 UTC

[GitHub] [servicecomb-service-center] humingcheng opened a new pull request #1168: Add query parameter "withShared"

humingcheng opened a new pull request #1168:
URL: https://github.com/apache/servicecomb-service-center/pull/1168


   Add query parameter "withShared" to control whether to return shared services, default: false.
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    - [ ] Never comment source code, delete it.
    - [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #1168: Add query parameter "withShared"

Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #1168:
URL: https://github.com/apache/servicecomb-service-center/pull/1168


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] humingcheng commented on pull request #1168: Add query parameter "withShared"

Posted by GitBox <gi...@apache.org>.
humingcheng commented on pull request #1168:
URL: https://github.com/apache/servicecomb-service-center/pull/1168#issuecomment-977602989


   已在PR说明中添加用户场景


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1168: Add query parameter "withShared"

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1168:
URL: https://github.com/apache/servicecomb-service-center/pull/1168#discussion_r755763126



##########
File path: go.mod
##########
@@ -13,10 +13,11 @@ require (
 	github.com/deckarep/golang-set v1.7.1
 	github.com/elithrar/simple-scrypt v1.3.0
 	github.com/ghodss/yaml v1.0.0
-	github.com/go-chassis/cari v0.5.1-0.20210823023004-74041d1363c4
+	github.com/go-chassis/cari v0.5.1-0.20211124031617-99bda218b0cf
 	github.com/go-chassis/foundation v0.3.1-0.20210811025651-7f4d2b2b906c
 	github.com/go-chassis/go-archaius v1.5.1
-	github.com/go-chassis/go-chassis-extension/protocol/grpc v0.0.0-20210902082902-eb5df922afcd // indirect
+	github.com/go-chassis/go-chassis v1.8.3 // indirect

Review comment:
       不对引入了错误的库，应该用v2

##########
File path: go.mod
##########
@@ -13,10 +13,11 @@ require (
 	github.com/deckarep/golang-set v1.7.1
 	github.com/elithrar/simple-scrypt v1.3.0
 	github.com/ghodss/yaml v1.0.0
-	github.com/go-chassis/cari v0.5.1-0.20210823023004-74041d1363c4
+	github.com/go-chassis/cari v0.5.1-0.20211124031617-99bda218b0cf
 	github.com/go-chassis/foundation v0.3.1-0.20210811025651-7f4d2b2b906c
 	github.com/go-chassis/go-archaius v1.5.1
-	github.com/go-chassis/go-chassis-extension/protocol/grpc v0.0.0-20210902082902-eb5df922afcd // indirect
+	github.com/go-chassis/go-chassis v1.8.3 // indirect

Review comment:
       引入了错误的库，应该用v2




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1168: Add query parameter "withShared"

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #1168:
URL: https://github.com/apache/servicecomb-service-center/pull/1168#issuecomment-977596045


   为什么需要增加这个功能，用例是什么，用户故事是什么


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] humingcheng commented on a change in pull request #1168: Add query parameter "withShared"

Posted by GitBox <gi...@apache.org>.
humingcheng commented on a change in pull request #1168:
URL: https://github.com/apache/servicecomb-service-center/pull/1168#discussion_r755777603



##########
File path: go.mod
##########
@@ -13,10 +13,11 @@ require (
 	github.com/deckarep/golang-set v1.7.1
 	github.com/elithrar/simple-scrypt v1.3.0
 	github.com/ghodss/yaml v1.0.0
-	github.com/go-chassis/cari v0.5.1-0.20210823023004-74041d1363c4
+	github.com/go-chassis/cari v0.5.1-0.20211124031617-99bda218b0cf
 	github.com/go-chassis/foundation v0.3.1-0.20210811025651-7f4d2b2b906c
 	github.com/go-chassis/go-archaius v1.5.1
-	github.com/go-chassis/go-chassis-extension/protocol/grpc v0.0.0-20210902082902-eb5df922afcd // indirect
+	github.com/go-chassis/go-chassis v1.8.3 // indirect

Review comment:
       已删除




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org