You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/04/16 06:58:57 UTC
[PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
zhengruifeng opened a new pull request, #55368:
URL: https://github.com/apache/spark/pull/55368
### What changes were proposed in this pull request?
Pin `meson<1.11.0` via `PIP_CONSTRAINT` when installing pandas for PyPy 3.10 in CI Dockerfiles (`dev/infra/Dockerfile` and `dev/spark-test-image/pypy-310/Dockerfile`).
### Why are the changes needed?
`pandas==2.3.3` has no pre-built wheel for PyPy 3.10, so pip builds it from source. The build system pulls in `meson==1.11.0` (newly released), which introduced a breaking change — `python.extension_module()` no longer accepts strings in the `dependencies` keyword. Pandas 2.3.3's `meson.build` still passes strings, causing:
```
../pandas/_libs/tslibs/meson.build:32:7: ERROR: python.extension_module keyword argument
'dependencies' was of type array[str] but should have been array[Dependency | InternalDependency]
```
This was previously hidden because the Docker layer was cached from a prior build with an older meson version. The cache was invalidated by the R devtools→remotes change in SPARK-56500, exposing the issue.
Failure: https://github.com/apache/spark/actions/runs/24489111484/job/71571576157
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI should validate that the Docker image builds successfully with the meson constraint.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on code in PR #55368:
URL: https://github.com/apache/spark/pull/55368#discussion_r3091358183
##########
dev/infra/Dockerfile:
##########
@@ -92,7 +92,7 @@ RUN mkdir -p /usr/local/pypy/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | pypy3
-RUN pypy3 -m pip install numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
+RUN pypy3 -m pip install 'meson<1.11.0' 'meson-python<0.16.0' numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
Review Comment:
Does this work? I confirmed `pypy3 -m pip install 'meson<1.11.0' numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml` doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #55368:
URL: https://github.com/apache/spark/pull/55368#issuecomment-4258060403
Thank you for fixing this, @zhengruifeng
I verified the same solution on my laptop too by `docker build`, and I noticed we may also need to pin `lxml` to `4.9.4`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #55368:
URL: https://github.com/apache/spark/pull/55368#discussion_r3091774444
##########
dev/infra/Dockerfile:
##########
@@ -92,7 +92,7 @@ RUN mkdir -p /usr/local/pypy/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | pypy3
-RUN pypy3 -m pip install numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
+RUN pypy3 -m pip install 'meson<1.11.0' 'meson-python<0.16.0' numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
Review Comment:
I cannot build image locally for now, still testing the fix.
Feel free to send a new fix to restore CI if it works :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on code in PR #55368:
URL: https://github.com/apache/spark/pull/55368#discussion_r3091358183
##########
dev/infra/Dockerfile:
##########
@@ -92,7 +92,7 @@ RUN mkdir -p /usr/local/pypy/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | pypy3
-RUN pypy3 -m pip install numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
+RUN pypy3 -m pip install 'meson<1.11.0' 'meson-python<0.16.0' numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
Review Comment:
Does this work? I confirmed `pypy3 -m pip install 'meson<1.11.0' numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml` which is similar to your change doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #55368: [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles
URL: https://github.com/apache/spark/pull/55368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #55368:
URL: https://github.com/apache/spark/pull/55368#issuecomment-4258064795
Also, I confirmed `RUN pypy3 -m pip install 'meson<1.11.0' 'meson-python<0.16.0' numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml` doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][INFRA] Pin meson<1.11.0 for PyPy pandas source build in CI Dockerfiles [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on code in PR #55368:
URL: https://github.com/apache/spark/pull/55368#discussion_r3091785368
##########
dev/infra/Dockerfile:
##########
@@ -92,7 +92,7 @@ RUN mkdir -p /usr/local/pypy/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3.10 && \
ln -sf /usr/local/pypy/pypy3.10/bin/pypy /usr/local/bin/pypy3
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | pypy3
-RUN pypy3 -m pip install numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
+RUN pypy3 -m pip install 'meson<1.11.0' 'meson-python<0.16.0' numpy 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib lxml
Review Comment:
OK, let me try to fix it too.
https://github.com/apache/spark/pull/55369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org