[GitHub] [spark] huaxingao commented on a diff in pull request #40889: [SPARK-41660][SQL][3.3] Only propagate metadata columns if they are used

["huaxingao (via GitHub)" <gi...@apache.org>]

huaxingao commented on code in PR #40889:
URL: https://github.com/apache/spark/pull/40889#discussion_r1173242176


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -925,7 +925,7 @@ class Analyzer(override val catalogManager: CatalogManager)
         if (metaCols.isEmpty) {
           node
         } else {
-          val newNode = addMetadataCol(node)
+          val newNode = node.mapChildren(addMetadataCol(_, metaCols.map(_.exprId).toSet))

Review Comment:
   The change is from this fix https://github.com/apache/spark/pull/39895



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org