You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailom-db (via GitHub)" <gi...@apache.org> on 2024/03/25 13:17:59 UTC
[PR] [FOLLOWUP][SPARK-47539] Remove test from ToPrettyStringSuite [spark]
mihailom-db opened a new pull request, #45698:
URL: https://github.com/apache/spark/pull/45698
### What changes were proposed in this pull request?
PR had a conflict, but tests were run at the same time with another PR and both were merged.
https://github.com/apache/spark/pull/45688
Change introduced is removal of unsupported test. Pattern matching, does not even look at VariantType and hard coded expected result broke master tests.
### Why are the changes needed?
Master tests are failing
### Does this PR introduce _any_ user-facing change?
Yes, toPrettyString was broken.
### How was this patch tested?
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [FOLLOWUP][SPARK-47539] Remove test from ToPrettyStringSuite [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #45698:
URL: https://github.com/apache/spark/pull/45698#issuecomment-2018083062
Let me adjust this Case about VariantType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [FOLLOWUP][SPARK-47539] Remove test from ToPrettyStringSuite [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #45698:
URL: https://github.com/apache/spark/pull/45698#issuecomment-2018223574
https://github.com/apache/spark/pull/45702 fixed the test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [FOLLOWUP][SPARK-47539] Remove test from ToPrettyStringSuite [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #45698:
URL: https://github.com/apache/spark/pull/45698#issuecomment-2018127489
New fix pr: https://github.com/apache/spark/pull/45702
<img width="1299" alt="image" src="https://github.com/apache/spark/assets/15246973/5258e144-fe3d-4a68-af8e-895a6587b18a">
cc @cloud-fan @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [FOLLOWUP][SPARK-47539] Remove test from ToPrettyStringSuite [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45698: [FOLLOWUP][SPARK-47539] Remove test from ToPrettyStringSuite
URL: https://github.com/apache/spark/pull/45698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org