You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by superbstreak <gi...@git.apache.org> on 2017/11/16 06:28:02 UTC

[GitHub] drill pull request #1039: DRILL-5584: Add branding and versioning informatio...

GitHub user superbstreak opened a pull request:

    https://github.com/apache/drill/pull/1039

    DRILL-5584: Add branding and versioning information for windows C++ C…

    …lient.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/superbstreak/drill DRILL-5584

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1039.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1039
    
----
commit 7792fbfa11dc9a622217eb9a8f4644802e4e5e44
Author: Rob Wu <ro...@gmail.com>
Date:   2017-11-16T02:21:48Z

    DRILL-5584: Add branding and versioning information for windows C++ Client.

----


---

[GitHub] drill pull request #1039: DRILL-5584: Add branding and versioning informatio...

Posted by superbstreak <gi...@git.apache.org>.

Github user superbstreak commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1039#discussion_r151329816
  
    --- Diff: contrib/native/client/src/clientlib/env.h.in ---
    @@ -30,6 +30,11 @@
     #define GIT_SHA_PROP  @GIT_SHA_PROP@
     #define GIT_COMMIT_PROP @GIT_COMMIT_PROP@
     
    +#define DRILL_LEGALCOPYRIGHT_STR    "Copyright (c) 2013-2017 The Apache Software Foundation\0"
    --- End diff --
    
    Reviewer, please make sure this is correct


---