You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "ubo-dev (via GitHub)" <gi...@apache.org> on 2023/11/28 19:44:10 UTC
[PR] 21580 @Deprecated added for newAck() methods [pulsar]
ubo-dev opened a new pull request, #21636:
URL: https://github.com/apache/pulsar/pull/21636
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #21580
<!-- or this PR is one task of an issue -->
Main Issue: #21580
<!-- If the PR belongs to a PIP, please add the PIP link here -->
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
Now we have 8 methods to create an ack command. We should consider to check which one is redundant.
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
@Deprecated annotation added for required methods.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/ubo-dev/pulsar/pull/2
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] #21580 @Deprecated added for newAck() methods [pulsar]
Posted by "ubo-dev (via GitHub)" <gi...@apache.org>.
ubo-dev commented on code in PR #21636:
URL: https://github.com/apache/pulsar/pull/21636#discussion_r1408955670
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java:
##########
@@ -976,6 +976,7 @@ public static ByteBuf newLookupErrorResponse(ServerError error, String errorMsg,
return serializeWithSize(newLookupErrorResponseCommand(error, errorMsg, requestId));
}
+ @Deprecated
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] #21580 @Deprecated added for newAck() methods [pulsar]
Posted by "ubo-dev (via GitHub)" <gi...@apache.org>.
ubo-dev commented on PR #21636:
URL: https://github.com/apache/pulsar/pull/21636#issuecomment-1832503513
> It's better to bring this to the mailing list to gain more visibility.
@RobertIndie Hi, I'm pretty new here, should I try to do that, how is the process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] #21580 @Deprecated added for newAck() methods [pulsar]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #21636:
URL: https://github.com/apache/pulsar/pull/21636#discussion_r1408571049
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java:
##########
@@ -976,6 +976,7 @@ public static ByteBuf newLookupErrorResponse(ServerError error, String errorMsg,
return serializeWithSize(newLookupErrorResponseCommand(error, errorMsg, requestId));
}
+ @Deprecated
Review Comment:
With reason or alternative suggestions?
Ditto others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] #21580 @Deprecated added for newAck() methods [pulsar]
Posted by "ubo-dev (via GitHub)" <gi...@apache.org>.
ubo-dev commented on PR #21636:
URL: https://github.com/apache/pulsar/pull/21636#issuecomment-1834446446
@tisonkun
`/**
* @deprecated use {@link #newMultiMessageAck(long consumerId, TxnID txnID, List<Triple<Long, Long, ConcurrentBitSetRecyclable>> entries, long requestID)
*/`
is there anything I should add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] #21580 @Deprecated added for newAck() methods [pulsar]
Posted by "ubo-dev (via GitHub)" <gi...@apache.org>.
ubo-dev closed pull request #21636: [improve] #21580 @Deprecated added for newAck() methods
URL: https://github.com/apache/pulsar/pull/21636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] #21580 @Deprecated added for newAck() methods [pulsar]
Posted by "ubo-dev (via GitHub)" <gi...@apache.org>.
ubo-dev commented on PR #21636:
URL: https://github.com/apache/pulsar/pull/21636#issuecomment-1834443001
@tisonkun I can handle the comments is there any templates that I should follow and should I open new PR for comments can I merge it with this one somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org