You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Lai Zhou (Jira)" <ji...@apache.org> on 2020/09/09 08:08:00 UTC

[jira] [Closed] (CALCITE-2992) Enhance implicit conversions when generating hash join keys for an equiCondition

     [ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lai Zhou closed CALCITE-2992.
-----------------------------
    Resolution: Fixed

> Enhance implicit conversions when generating hash join keys for an equiCondition
> --------------------------------------------------------------------------------
>
>                 Key: CALCITE-2992
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2992
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: Lai Zhou
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Considering follow sql join:
>  
> {code:java}
> select t1.*,t2.*  from t1 join t2 on t1.intValue=t2.longValue
> {code}
> as known in java :
>  
> {code:java}
> Integer intValue = 2;
> Long longValue = 2L;
> new Object[]{intValue}.hashCode().equals
> (
> new Object[]{longValue}.hashCode()
> )
> = false;
> {code}
> We shoudn't use the orginal Object as a key in the HashMap,
> I think it'd be better to convert hash join keys to string and compare string values.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)