You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:43:21 UTC

[GitHub] [druid] suneet-s removed a comment on pull request #9449: Add Sql InputSource

suneet-s removed a comment on pull request #9449:
URL: https://github.com/apache/druid/pull/9449#issuecomment-641327302


   > I wrote my thought [here](https://github.com/apache/druid/pull/9449#discussion_r435645608). It maybe makes sense to call all InputSources Beta or something depending on what Beta means. However, we don't have such feature tags yet and so it should be discussed separately instead of in this PR.
   > 
   > Regarding integration tests, I would say the original author or anyone can add it later. I think it's better to not add it in this PR since we don't have a framework to easily add such a test yet, which mean the PR size can grow large. We can open an issue for those integration tests and tag the next major release version so that those issues become release blockers.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org