You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "r-sidd (via GitHub)" <gi...@apache.org> on 2023/05/19 10:18:47 UTC
[GitHub] [nifi] r-sidd opened a new pull request, #7270: Nifi 10611 upgrade ignite-core to 2.13.0
r-sidd opened a new pull request, #7270:
URL: https://github.com/apache/nifi/pull/7270
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
URL: https://github.com/apache/nifi/pull/7270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7270:
URL: https://github.com/apache/nifi/pull/7270#issuecomment-1554544047
> Also `ignite-spring` has the old version. This should be moved to a Maven property named `ignite.version` and reused.
Got it, will do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7270:
URL: https://github.com/apache/nifi/pull/7270#issuecomment-1554570857
Pushed the new changes @exceptionfactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #7270:
URL: https://github.com/apache/nifi/pull/7270#issuecomment-1559943207
Thanks for the work on this @r-sidd. Although the unit tests pass, they use a mocked Ignite Processor that does not exercise actual behavior.
The integration tests fail to run when attempting connect to the internal test server.
The [Apache Ignite 2.0 Migration Guide](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide) highlights a number of important changes, so I'm not surprised this is failing. The current Processor implementations rely on a Spring Configuration file, which is not the best approach, and these Processors have not been maintained since the original contribution in 2016. With that background, I will plan on deprecating and removing them for NiFi 2.0 in a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7270:
URL: https://github.com/apache/nifi/pull/7270#issuecomment-1561348649
> Thanks for the work on this @r-sidd. Although the unit tests pass, they use a mocked Ignite Processor that does not exercise actual behavior.
>
> The integration tests fail to run when attempting connect to the internal test server.
>
> The [Apache Ignite 2.0 Migration Guide](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide) highlights a number of important changes, so I'm not surprised this is failing. The current Processor implementations rely on a Spring Configuration file, which is not the best approach, and these Processors have not been maintained since the original contribution in 2016. With that background, I will plan on deprecating and removing them for NiFi 2.0 in a separate issue.
Makes sense, thanks for the explanation 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7270:
URL: https://github.com/apache/nifi/pull/7270#issuecomment-1554542087
> Thanks for contribution @r-sidd. The Maven configuration also includes an `ignite-slf4j` library version that needs to be updated.
I'm sorry about that, let me commit and push the changes. Bumping both `ignite-slf4j` and `ignite-spring` to 2.15.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #7270:
URL: https://github.com/apache/nifi/pull/7270#issuecomment-1554537300
Also `ignite-spring` has the old version. This should be moved to a Maven property named `ignite.version` and reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org