You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/07/18 08:13:55 UTC
[PR] [ISSUE #4022] contains() is a legacy method that is equivalent to containsValue() (eventmesh)
harshithasudhakar opened a new pull request, #4249:
URL: https://github.com/apache/eventmesh/pull/4249
Fixes #4022
### Motivation
`containsValue()` method is used to check whether a particular value is being mapped by a single or more than one key in the HashMap. It is more appropriate to use `containsValue()` here, than `contains()`.
### Modifications
Changed `contains()` to `containsValue()` at line 190.
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4022]contains() is a legacy method that is equivalent to containsValue() (eventmesh)
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #4249:
URL: https://github.com/apache/eventmesh/pull/4249#issuecomment-1641249129
One pr corresponds to one issue, and these two changes can be accomplished with one pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4022]contains() is a legacy method that is equivalent to containsValue() (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4249:
URL: https://github.com/apache/eventmesh/pull/4249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4022]contains() is a legacy method that is equivalent to containsValue() (eventmesh)
Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar commented on PR #4249:
URL: https://github.com/apache/eventmesh/pull/4249#issuecomment-1641532624
@Alonexc Done. It can now be accomplished with one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4022]contains() is a legacy method that is equivalent to containsValue() (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4249:
URL: https://github.com/apache/eventmesh/pull/4249#issuecomment-1641741814
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4249](https://app.codecov.io/gh/apache/eventmesh/pull/4249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca4df90) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/cc43deef549d8b4869b8c544474200594aa2691d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cc43dee) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head ca4df90 differs from pull request most recent head fcee9e6. Consider uploading reports for the commit fcee9e6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4249 +/- ##
============================================
- Coverage 16.77% 16.76% -0.01%
- Complexity 1415 1416 +1
============================================
Files 592 592
Lines 26040 26036 -4
Branches 2400 2386 -14
============================================
- Hits 4367 4366 -1
+ Misses 21235 21234 -1
+ Partials 438 436 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...esh/registry/consul/service/HeatBeatScheduler.java](https://app.codecov.io/gh/apache/eventmesh/pull/4249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvcmVnaXN0cnkvY29uc3VsL3NlcnZpY2UvSGVhdEJlYXRTY2hlZHVsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/eventmesh/client/tcp/common/TcpClient.java](https://app.codecov.io/gh/apache/eventmesh/pull/4249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L3RjcC9jb21tb24vVGNwQ2xpZW50LmphdmE=) | `15.30% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4249/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org