You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "VGalaxies (via GitHub)" <gi...@apache.org> on 2024/09/09 02:18:21 UTC
[PR] Pipe: perform deep copy for incoming progress index when constructing and updating progress index & fix hash code of progress index [iotdb]
VGalaxies opened a new pull request, #13441:
URL: https://github.com/apache/iotdb/pull/13441
TBD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: perform deep copy for incoming progress index when constructing and updating progress index & fix hash code of progress index [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on code in PR #13441:
URL: https://github.com/apache/iotdb/pull/13441#discussion_r1756865507
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/impl/RecoverProgressIndex.java:
##########
@@ -47,15 +49,19 @@ private RecoverProgressIndex() {
}
public RecoverProgressIndex(int dataNodeId, SimpleProgressIndex simpleProgressIndex) {
- this.dataNodeId2LocalIndex = new HashMap<>();
+ this(ImmutableMap.of(dataNodeId, simpleProgressIndex));
Review Comment:
```suggestion
this(ImmutableMap.of(dataNodeId, simpleProgressIndex.deepCopy()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: perform deep copy for incoming progress index when constructing and updating progress index & fix hash code of progress index [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #13441:
URL: https://github.com/apache/iotdb/pull/13441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org