[GitHub] [incubator-doris] xinghuayu007 commented on pull request #5644: [Optimize]not need to deserialize twice

[GitBox <gi...@apache.org>]

xinghuayu007 commented on pull request #5644:
URL: https://github.com/apache/incubator-doris/pull/5644#issuecomment-819961806


   > `Deserialization` here may be necessary. To ensure the tablet meta that will be stored in rocksdb is no problem and can be deserialized successfully, so deserializing the `meta_binary` here before saving it into rocksdb.
   > I think it may be not a good practice to remove this part of the code.
   
   Yes, it is important. But it is no need to deserialize twice. In serialize() Function, it has been deserialized to check the result.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org