You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Hanifi Gunes (JIRA)" <ji...@apache.org> on 2015/04/08 08:59:12 UTC

[jira] [Created] (DRILL-2719) Behavior of ValueVector#getBuffers(clear) is inconsistent across VV types

Hanifi Gunes created DRILL-2719:
-----------------------------------

             Summary: Behavior of ValueVector#getBuffers(clear) is inconsistent across VV types
                 Key: DRILL-2719
                 URL: https://issues.apache.org/jira/browse/DRILL-2719
             Project: Apache Drill
          Issue Type: Bug
            Reporter: Hanifi Gunes
            Assignee: Hanifi Gunes


The major cause of inconsistency here is that reference count does not change upon a call to BaseDataVV#getBuffers. However, it does change when the method is invoked on a composite vector type. See for instance VariableLengthVV[1] or a NullableVV[2].

The proposal is to make this behavior consistent first and later we can consider separating out the logic that clears a vector from the logic that returns underlying buffers.

[1]: https://github.com/apache/drill/blob/master/exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java#L151
[2]: https://github.com/apache/drill/blob/master/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java#L82




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)