You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/04 09:25:41 UTC
[GitHub] twalthr commented on a change in pull request #7228:
[FLINK-9740][Table API &SQL] Support group windows over intervals of months
twalthr commented on a change in pull request #7228: [FLINK-9740][Table API &SQL] Support group windows over intervals of months
URL: https://github.com/apache/flink/pull/7228#discussion_r238582610
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/time/Time.java
##########
@@ -124,4 +124,11 @@ public static Time hours(long hours) {
public static Time days(long days) {
return of(days, TimeUnit.DAYS);
}
+
+ /**
+ * Creates a new {@link Time} that represents the given number of months.
+ */
+ public static Time months(long months) {
+ return of(months, TimeUnit.DAYS);
Review comment:
This is not months.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services