You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/01/02 18:58:33 UTC

Re: Review Request 16360: Address Jun's comments

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16360/#review31041
-----------------------------------------------------------



core/src/main/scala/kafka/cluster/Partition.scala
<https://reviews.apache.org/r/16360/#comment59388>

    This comment is no longer valid.



core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/16360/#comment59387>

    The ordering of correlationId and controllerId is reversed.



core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/16360/#comment59386>

    fetchers -> fetcher


- Jun Rao


On Dec. 24, 2013, 7:07 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16360/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2013, 7:07 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1188
>     https://issues.apache.org/jira/browse/KAFKA-1188
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1118.v2
> 
> 
> KAFKA-1188.v1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/cluster/Partition.scala 5c9307d71641ccc6c09a54b69d5aa2b4bc2a4cde 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 242c18d47828b7c5e6b1fc219a0f1199fb1f9512 
> 
> Diff: https://reviews.apache.org/r/16360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>