You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/23 19:05:05 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12948: [Protocol] Add guidance to send CloseProducer before sending Producer…

michaeljmarshall opened a new pull request #12948:
URL: https://github.com/apache/pulsar/pull/12948


   … in case of client side timeout
   
   ### Motivation
   
   As discussed on the mailing list here, https://lists.apache.org/thread/tko0z4jg0oq0yf931rbow2zf9fq8wjt1, it is most ideal for the client to send a `CloseProducer` command before sending a subsequent `Producer` command when the client timeouts out the original `Producer` request.
   
   This PR updates the protocol documentation. I will submit a PR to update the Java client once this PR is merged.
   
   ### Modifications
   
   * Update current docs for protocol
   * Update next docs for protocol
   
   ### Verifying this change
   
   This is just a change to documentation.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: yes
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   Regarding the change to the wire protocol, this is simply an expansion on a currently ambiguous portion of the protocol. I've discussed this change on the mailing list.
   
   ### Documentation
   - [x] `doc` 
     
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #12948: [Protocol] Add guidance to send CloseProducer before sending Producer…

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12948:
URL: https://github.com/apache/pulsar/pull/12948#issuecomment-977406424


   @codelipenghui can you review it from the technical perspective? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #12948: [Protocol] Add guidance to send CloseProducer before sending Producer…

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12948:
URL: https://github.com/apache/pulsar/pull/12948


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org