You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/01/11 16:13:00 UTC
[jira] [Commented] (THRIFT-4732) increase cmake minimal required
version and cleanup cmake scripts
[ https://issues.apache.org/jira/browse/THRIFT-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740522#comment-16740522 ]
James E. King III commented on THRIFT-4732:
-------------------------------------------
My preference would be ~3.5. I've only moved this forward when I add a new thing that requires it to move. In work I have done to support Docker for Windows building locally, which I will submit a PR for shortly, I have moved it to 3.3. For reference, Ubuntu Xenial 16.04 LTS has cmake version 3.5.1 in it. Bionic has 3.10.2 in it.
We're going to collide here, and I could probably tuck in this export all directive into the work I am doing right now.
> increase cmake minimal required version and cleanup cmake scripts
> -----------------------------------------------------------------
>
> Key: THRIFT-4732
> URL: https://issues.apache.org/jira/browse/THRIFT-4732
> Project: Thrift
> Issue Type: Improvement
> Reporter: yuanyuan chen
> Priority: Major
>
> In order to use modern cmake syntax to cleanup building scripts and add shared library support on Windows by using [[windows_export_all_symbol| https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html].|https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html]
> So I think it is a good idea to increase cmake minimal required version.May be 3.10 is a good alternative version?
> h1.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)