You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2004/12/07 06:43:23 UTC
Re: [mp2] $(ABSPERLRUN) in src/modules/perl/Makefile
Randy Kobes wrote:
> In Apache::BuildConfig, there's some functions (eg, mv) that
> are defined within the generated Makefile as
> $(ABSPERLRUN) -MExtUtils::Command -e mv
> (for those platforms for which a system 'mv' isn't
> available). However, src/modules/perl/Makefile.PL doesn't
> define $(ABSPERLRUN) (it does define $(MODPERL_PERLPATH)).
> I'm not sure of the desired way to fix this - define
> $(ABSPERLRUN), or use $(MODPERL_PERLPATH)?
>
src/modules/perl/Makefile.PL? You mean src/modules/perl/Makefile, right?
Are the two identical? $(ABSPERLRUN) and $(MODPERL_PERLPATH)?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] $(ABSPERLRUN) in src/modules/perl/Makefile
Posted by Stas Bekman <st...@stason.org>.
>>+ ABSPERL => 'perlpath',
>>+ ABSPERLRUN => 'perlpath',
> That works fine - thanks!
Thanks. Committed.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] $(ABSPERLRUN) in src/modules/perl/Makefile
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 7 Dec 2004, Stas Bekman wrote:
> Randy Kobes wrote:
>
> >>>In Apache::BuildConfig, there's some functions (eg, mv) that
> >>>are defined within the generated Makefile as
> >>> $(ABSPERLRUN) -MExtUtils::Command -e mv
> >>>(for those platforms for which a system 'mv' isn't
> >>>available). However, src/modules/perl/Makefile.PL doesn't
> >>>define $(ABSPERLRUN) (it does define $(MODPERL_PERLPATH)).
> >>>I'm not sure of the desired way to fix this - define
> >>>$(ABSPERLRUN), or use $(MODPERL_PERLPATH)?
> [...]
>
> Please try:
>
> Index: lib/Apache/Build.pm
> ===================================================================
> --- lib/Apache/Build.pm (revision 110107)
> +++ lib/Apache/Build.pm (working copy)
> @@ -1322,6 +1322,8 @@
>
> #when we use a bit of MakeMaker, make it use our values for these vars
> my %perl_config_pm_alias = (
> + ABSPERL => 'perlpath',
> + ABSPERLRUN => 'perlpath',
> PERL => 'perlpath',
> PERLRUN => 'perlpath',
> PERL_LIB => 'privlibexp',
> @@ -1330,9 +1332,8 @@
>
> my $mm_replace = join '|', keys %perl_config_pm_alias;
>
> -my @perl_config_pm =
> - (qw(cc cpprun rm ranlib lib_ext obj_ext cccdlflags lddlflags optimize),
> - values %perl_config_pm_alias);
> +my @perl_config_pm = (values(%perl_config_pm_alias), qw(cc cpprun
> + rm ranlib lib_ext obj_ext cccdlflags lddlflags optimize));
>
> sub mm_replace {
> my $val = shift;
> ------------------------
That works fine - thanks!
> once this is applied we need to clean
>
> values(%perl_config_pm_alias)
>
> from dups.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] $(ABSPERLRUN) in src/modules/perl/Makefile
Posted by Stas Bekman <st...@stason.org>.
> +ABSPERL = $(MODPERL_PERLPATH)
> +ABSPERLRUN = $(MODPERL_PERLPATH)
Also do we need both, or just one is enough? I suppose it won't harm to
have both.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] $(ABSPERLRUN) in src/modules/perl/Makefile
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
>>>In Apache::BuildConfig, there's some functions (eg, mv) that
>>>are defined within the generated Makefile as
>>> $(ABSPERLRUN) -MExtUtils::Command -e mv
>>>(for those platforms for which a system 'mv' isn't
>>>available). However, src/modules/perl/Makefile.PL doesn't
>>>define $(ABSPERLRUN) (it does define $(MODPERL_PERLPATH)).
>>>I'm not sure of the desired way to fix this - define
>>>$(ABSPERLRUN), or use $(MODPERL_PERLPATH)?
[...]
Please try:
Index: lib/Apache/Build.pm
===================================================================
--- lib/Apache/Build.pm (revision 110107)
+++ lib/Apache/Build.pm (working copy)
@@ -1322,6 +1322,8 @@
#when we use a bit of MakeMaker, make it use our values for these vars
my %perl_config_pm_alias = (
+ ABSPERL => 'perlpath',
+ ABSPERLRUN => 'perlpath',
PERL => 'perlpath',
PERLRUN => 'perlpath',
PERL_LIB => 'privlibexp',
@@ -1330,9 +1332,8 @@
my $mm_replace = join '|', keys %perl_config_pm_alias;
-my @perl_config_pm =
- (qw(cc cpprun rm ranlib lib_ext obj_ext cccdlflags lddlflags optimize),
- values %perl_config_pm_alias);
+my @perl_config_pm = (values(%perl_config_pm_alias), qw(cc cpprun
+ rm ranlib lib_ext obj_ext cccdlflags lddlflags optimize));
sub mm_replace {
my $val = shift;
------------------------
and if this doesn't do the trick, this instead:
Index: lib/Apache/Build.pm
===================================================================
--- lib/Apache/Build.pm (revision 110107)
+++ lib/Apache/Build.pm (working copy)
@@ -1330,9 +1330,8 @@
my $mm_replace = join '|', keys %perl_config_pm_alias;
-my @perl_config_pm =
- (qw(cc cpprun rm ranlib lib_ext obj_ext cccdlflags lddlflags optimize),
- values %perl_config_pm_alias);
+my @perl_config_pm = (values(%perl_config_pm_alias), qw(cc cpprun
+ rm ranlib lib_ext obj_ext cccdlflags lddlflags optimize));
sub mm_replace {
my $val = shift;
@@ -1349,6 +1348,13 @@
print $fh $self->canon_make_attr($_, $self->perl_config($_));
}
+ # default MM tools rely on ABSPERL
+ print $fh <<'EOI';
+ABSPERL = $(MODPERL_PERLPATH)
+ABSPERLRUN = $(MODPERL_PERLPATH)
+
+EOI
+
require ExtUtils::MakeMaker;
my $mm = bless { @mm_init_vars }, 'MM';
$mm->init_main;
------------------------
once this is applied we need to clean
values(%perl_config_pm_alias)
from dups.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] $(ABSPERLRUN) in src/modules/perl/Makefile
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 7 Dec 2004, Stas Bekman wrote:
> Randy Kobes wrote:
> > In Apache::BuildConfig, there's some functions (eg, mv) that
> > are defined within the generated Makefile as
> > $(ABSPERLRUN) -MExtUtils::Command -e mv
> > (for those platforms for which a system 'mv' isn't
> > available). However, src/modules/perl/Makefile.PL doesn't
> > define $(ABSPERLRUN) (it does define $(MODPERL_PERLPATH)).
> > I'm not sure of the desired way to fix this - define
> > $(ABSPERLRUN), or use $(MODPERL_PERLPATH)?
> >
>
> src/modules/perl/Makefile.PL? You mean src/modules/perl/Makefile, right?
Yes, that's right - sorry about that.
> Are the two identical? $(ABSPERLRUN) and $(MODPERL_PERLPATH)?
On my system they are - src/modules/perl/Makefile has
$(MODPERL_PERLPATH) as D:\Perl\bin\perl.exe, while
the top-level Makefile has $(ABSPERLRUN) as $(ABSPERL),
and $(ABSPERL) as $(PERL), and $(PERL) as
D:\Perl\bin\perl.exe.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org