You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org> on 2023/10/29 23:57:05 UTC
[PR] FINERACT-1761: Loan Product repayment due event values set by default… [fineract]
josehernandezfintecheandomx opened a new pull request, #3546:
URL: https://github.com/apache/fineract/pull/3546
… from global configurations
## Description
As part of Loan Product enhancements in the create and edit actions some values are being used from the Global Configuration. In particular the Event (notifications) settings values, so those values must to be remarked to indicated the default value is set from the GLobal Configuration
[FINERACT-1761](https://issues.apache.org/jira/browse/FINERACT-1761)
<img width="1306" alt="Screenshot 2023-10-29 at 5 52 18 p m" src="https://github.com/apache/fineract/assets/44206706/b7555558-f97f-4d43-95e4-7331373030d3">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1761: Loan Product repayment due event values set by default… [fineract]
Posted by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org>.
josehernandezfintecheandomx commented on PR #3546:
URL: https://github.com/apache/fineract/pull/3546#issuecomment-1794803441
TLDR... Not needed it more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1761: Loan Product repayment due event values set by default… [fineract]
Posted by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org>.
josehernandezfintecheandomx closed pull request #3546: FINERACT-1761: Loan Product repayment due event values set by default…
URL: https://github.com/apache/fineract/pull/3546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1761: Loan Product repayment due event values set by default… [fineract]
Posted by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org>.
josehernandezfintecheandomx commented on PR #3546:
URL: https://github.com/apache/fineract/pull/3546#issuecomment-1794803004
TLDR... Not needed it more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org