You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/08/23 19:36:20 UTC
Review Request 68491: RANGER-2197: Delegate Admin is not able to
create policy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68491/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
Bugs: RANGER-2197
https://issues.apache.org/jira/browse/RANGER-2197
Repository: ranger
Description
-------
Delegate Admin is not able to create policy, because of NPE in RangerDefaultPolicyEvaluator.isMatch() method.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 76ff0f745
Diff: https://reviews.apache.org/r/68491/diff/1/
Testing
-------
Passes all unit tests
Thanks,
Abhay Kulkarni
Re: Review Request 68491: RANGER-2197: Delegate Admin is not able to
create policy
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68491/#review207836
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 23, 2018, 9:28 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68491/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 9:28 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2197
> https://issues.apache.org/jira/browse/RANGER-2197
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Delegate Admin is not able to create policy, because of NPE in RangerDefaultPolicyEvaluator.isMatch() method.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 76ff0f745
>
>
> Diff: https://reviews.apache.org/r/68491/diff/2/
>
>
> Testing
> -------
>
> Passes all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 68491: RANGER-2197: Delegate Admin is not able to
create policy
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68491/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 9:28 p.m.)
Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
Changes
-------
Addressed a case where delegate admin user updates policy with resource that they dont have admin permission on.
Bugs: RANGER-2197
https://issues.apache.org/jira/browse/RANGER-2197
Repository: ranger
Description
-------
Delegate Admin is not able to create policy, because of NPE in RangerDefaultPolicyEvaluator.isMatch() method.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 76ff0f745
Diff: https://reviews.apache.org/r/68491/diff/2/
Changes: https://reviews.apache.org/r/68491/diff/1-2/
Testing
-------
Passes all unit tests
Thanks,
Abhay Kulkarni