You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/18 20:21:00 UTC

[jira] [Commented] (MPLUGIN-407) Remove duplicate code from PluginReport

    [ https://issues.apache.org/jira/browse/MPLUGIN-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568187#comment-17568187 ] 

ASF GitHub Bot commented on MPLUGIN-407:
----------------------------------------

michael-o commented on PR #120:
URL: https://github.com/apache/maven-plugin-tools/pull/120#issuecomment-1188264394

   Please go ahead and merge this.




> Remove duplicate code from PluginReport
> ---------------------------------------
>
>                 Key: MPLUGIN-407
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-407
>             Project: Maven Plugin Tools
>          Issue Type: Task
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>
> In {{PluginReport}} we try to read plugin descriptor if some problem occurs in this step we have copied code from {{AbstractGeneratorMojo}} which try to generate plugin descriptor again.
> Reports is skipped at all if {{plugin.xml}} doesn't exist ... so fallback will not be used ...
> {{plugin.xml}} is generated by {{descriptor}} goal so if we have code in sync - fallback will do the same.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)