You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lh0156 (via GitHub)" <gi...@apache.org> on 2026/08/02 17:40:27 UTC
[PR] KAFKA-20679: Remove deprecated Yammer group coordinator metrics [kafka]
lh0156 opened a new pull request, #23031:
URL: https://github.com/apache/kafka/pull/23031
## Summary
- Remove the deprecated Yammer-based group coordinator metrics scheduled for removal in Kafka 5.0.
- Simplify `GroupCoordinatorMetrics` to use Kafka Metrics only, including its constructor, registration, and cleanup paths.
- Update the broker, benchmark, coordinator tests, test utilities, and monitoring documentation for the Kafka Metrics replacements.
- Jira: https://issues.apache.org/jira/browse/KAFKA-20679
## TDD verification
- RED: on the baseline, a test asserting that deprecated Yammer metrics are not registered failed because the old gauges were present (`expected: <true> but was: <false>`).
- GREEN: after the production removal, the coordinator metrics tests pass and the deprecated Yammer APIs are no longer referenced in the affected paths.
## Testing
- `./gradlew :group-coordinator:test --tests org.apache.kafka.coordinator.group.metrics.GroupCoordinatorMetricsTest --tests org.apache.kafka.coordinator.group.metrics.GroupCoordinatorMetricsShardTest --no-build-cache --console=plain`
- `./gradlew :group-coordinator:test --no-build-cache --console=plain`
- `./gradlew :core:compileScala :jmh-benchmarks:compileJava --no-build-cache --console=plain --quiet`
- Checkstyle and SpotBugs completed successfully as part of the coordinator test task.
- `git diff --check`
The deprecated metrics were explicitly marked for Kafka 5.0 removal in KIP-1301, and the replacement metrics remain covered by the existing Kafka Metrics assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20679: Remove deprecated Yammer group coordinator metrics [kafka]
Posted by "squah-confluent (via GitHub)" <gi...@apache.org>.
squah-confluent commented on PR #23031:
URL: https://github.com/apache/kafka/pull/23031#issuecomment-5164858864
Thanks for the PR. Please note that the 5.0 release is nowhere near to being cut yet and there are future 4.x releases planned, which should not include this change. We cannot merge the removal into trunk any time soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20679: Remove deprecated Yammer group coordinator metrics [kafka]
Posted by "lh0156 (via GitHub)" <gi...@apache.org>.
lh0156 closed pull request #23031: KAFKA-20679: Remove deprecated Yammer group coordinator metrics
URL: https://github.com/apache/kafka/pull/23031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20679: Remove deprecated Yammer group coordinator metrics [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23031:
URL: https://github.com/apache/kafka/pull/23031#issuecomment-5235602282
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20679: Remove deprecated Yammer group coordinator metrics [kafka]
Posted by "lh0156 (via GitHub)" <gi...@apache.org>.
lh0156 commented on PR #23031:
URL: https://github.com/apache/kafka/pull/23031#issuecomment-5301415079
Thanks for the clarification. Since this removal cannot target trunk until Kafka 5.0 and future 4.x releases still need these metrics, I'm closing this PR. The Jira can be revisited when the target release window is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org