You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/01/31 23:38:41 UTC
[GitHub] [helix] narendly opened a new pull request #710: Enable two test
runs with multiZk system property
narendly opened a new pull request #710: Enable two test runs with multiZk system property
URL: https://github.com/apache/helix/pull/710
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Resolves #709
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
We want to achieve horizontal scalability for ZK, meaning we want to allow users to add more ZK deployments and shard based on the ZK read/write path. To test this going forward, we want to be able to execute existing tests in two different environments: 1. single-ZK env, and 2. multi-ZK env.
Changelist:
1. Create two executions for maven-surefire-plugin with multiZk system property
### Tests
Manually tested
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #710: Enable two test runs
with multiZk system property
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #710: Enable two test runs with multiZk system property
URL: https://github.com/apache/helix/pull/710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on issue #710: Enable two test runs with
multiZk system property
Posted by GitBox <gi...@apache.org>.
narendly commented on issue #710: Enable two test runs with multiZk system property
URL: https://github.com/apache/helix/pull/710#issuecomment-580970958
This PR is ready to be merged, approved by @NealSun96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org