You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2023/01/16 11:12:07 UTC

[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

kasjer commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1071117722


##########
apps/bleprph_oic/syscfg.yml:
##########
@@ -25,6 +25,10 @@ syscfg.defs:
         value: 0
 
 syscfg.vals:
+    CONSOLE_MODE: full

Review Comment:
   I would deprecate _MODE it was first attempt. Later on for logs _IMPLEMENTATION was chosen as it more clear what it does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org